79804 - unchecking download folder for offline use in folder properties no longer works

Status: VERIFIED DUPLICATE of bug 71128

(SeaMonkey :: MailNews: Backend, defect, P2)

Description

[David :Bienvenu]

unchecking download folder for offline use in folder properties no longer works
- next time you bring up the folder properties, the checkbox is still checked.

Comment 1

[scottputterman]

moving to 0.9.1

Comment 2

[David :Bienvenu]

Attachment: proposed fix

Comment 3

[David :Bienvenu]

Can I get some reviews on this? I removed the checks on a couple other elements
that are, as near as I can tell, irrelevant to the folder properties dialog and
it works for me again.

Comment 4

[Mohan Bhamidipati]

I have attached patch for 78900, 79804, 78891, 67607, 71128, 79097; with 71128.
bienvenu : would you please check this?

Comment 5

[(not reading, please use [e-mail] instead)]

bienvenu, who added that code in the first place?  can you get them to review
first and then I'll super review.

Comment 6

[David :Bienvenu]

I think it was Mohan - he's working on a fix in bug 71128 but I'm not convinced
the fix doesn't have the same problem as the current code.

Comment 7

[(not reading, please use [e-mail] instead)]

sr=sspitzer

your fix makes sense.  as far as #71128 goes, I'll add a comment in there.

Comment 8

[(not reading, please use [e-mail] instead)]

actually, hold up.

looking at 71128 and the the UI, I'm really confused.

Comment 9

[David :Bienvenu]

I'll let the fix for 71128 fix this.

*** This bug has been marked as a duplicate of 71128 ***

Comment 10

[grylchan]

verifying as dupe