mozilla::gfx::Scale always returns false

RESOLVED FIXED in mozilla19

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: joe, Assigned: joe)

Tracking

unspecified
mozilla19
x86
macOS
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

7 years ago
Due (I think) to semantics of SkBitmap, Scale is always returning false, indicating failure. SkBitmap::readyToDraw() is returning false on an SkBitmap with only a pixelRef (ie no direct pixels). These are naturally created by returning SkBitmaps that I back with a setPixels() call.

This patch fixes this specific bug, but I don't know if it's correct, or if readyToDraw() should be changed.
Attachment #668194 - Flags: review?(gwright)
Would SkBitmap::isNull() be better instead of readyToDraw()?
Assignee

Comment 2

7 years ago
Whatever means "Is this a good result that could be drawn if all the relevant Skia dances were done" is what I want.
OK that seems fine. I don't think locking is an expensive operation anyway.
Attachment #668194 - Flags: review?(gwright) → review+
Assignee

Comment 4

7 years ago
Posted patch use isNullSplinter Review
Attachment #668194 - Attachment is obsolete: true
Attachment #668252 - Flags: review?(gwright)
Attachment #668252 - Flags: review?(gwright) → review+
https://hg.mozilla.org/mozilla-central/rev/dbcb02897678

Should this have a test?
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Assignee

Comment 7

7 years ago
Testing this depends on testing downscaling in general, which is bug 795371.
You need to log in before you can comment on or make changes to this bug.