Created attachment 668194 [details] [diff] [review] lock result to ensure pixels is set Due (I think) to semantics of SkBitmap, Scale is always returning false, indicating failure. SkBitmap::readyToDraw() is returning false on an SkBitmap with only a pixelRef (ie no direct pixels). These are naturally created by returning SkBitmaps that I back with a setPixels() call. This patch fixes this specific bug, but I don't know if it's correct, or if readyToDraw() should be changed.
Attachment #668194 - Flags: review?(gwright)
Would SkBitmap::isNull() be better instead of readyToDraw()?
Whatever means "Is this a good result that could be drawn if all the relevant Skia dances were done" is what I want.
OK that seems fine. I don't think locking is an expensive operation anyway.
Attachment #668194 - Flags: review?(gwright) → review+
Created attachment 668252 [details] [diff] [review] use isNull
Attachment #668252 - Flags: review?(gwright) → review+
Target Milestone: --- → mozilla19
https://hg.mozilla.org/mozilla-central/rev/dbcb02897678 Should this have a test?
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Testing this depends on testing downscaling in general, which is bug 795371.
You need to log in before you can comment on or make changes to this bug.