798053 - mozilla::gfx::Scale always returns false

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Joe Drew (not getting mail)]

Attachment: lock result to ensure pixels is set

Due (I think) to semantics of SkBitmap, Scale is always returning false, indicating failure. SkBitmap::readyToDraw() is returning false on an SkBitmap with only a pixelRef (ie no direct pixels). These are naturally created by returning SkBitmaps that I back with a setPixels() call.

This patch fixes this specific bug, but I don't know if it's correct, or if readyToDraw() should be changed.

Comment 1

[George Wright (:gw280) (needinfo me!)]

Would SkBitmap::isNull() be better instead of readyToDraw()?

Comment 2

[Joe Drew (not getting mail)]

Whatever means "Is this a good result that could be drawn if all the relevant Skia dances were done" is what I want.

Comment 3

[George Wright (:gw280) (needinfo me!)]

OK that seems fine. I don't think locking is an expensive operation anyway.

Comment 4

[Joe Drew (not getting mail)]

Attachment: use isNull

Comment 5

[Joe Drew (not getting mail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbcb02897678

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dbcb02897678

Should this have a test?

Comment 7

[Joe Drew (not getting mail)]

Testing this depends on testing downscaling in general, which is bug 795371.