798090 - Write test add-on(s) for simple-prefs

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

Now that bug 791577 has landed we can implement tests that will make sure that simple-prefs are properly displayed in Firefox and Fennec.  This should be done before more changes to simple-prefs are made.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/999

Pointer to Github pull-request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 750516 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/999

This pull request is now 2 months old, I'm giving it to someone else.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 750516 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/999

Some nits -- also, is it possible to test this on Fennec as well? Does Fennec support simple-prefs? If so, let's open up another bug for that and nest it under bug 787352.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #3)
> Comment on attachment 750516 [details]
> Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/999
> 
> Some nits -- also, is it possible to test this on Fennec as well? Does
> Fennec support simple-prefs? If so, let's open up another bug for that and
> nest it under bug 787352.

simple-prefs do work on Fennec, but these interface tests would need to be written differently, I think, maybe not.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/c23fada976a160973b74ed368b83b8b3262f9184
Bug 798090: Adding test add-on for simple-prefs

https://github.com/mozilla/addon-sdk/commit/a877a66116d06603cfbe0a0de104ad7068c0641d
Merge pull request #999 from erikvold/798090

Bug 798090: Adding test add-on for simple-prefs r=@jsantell

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

This looks merged -- closing