798123 - Replace the array conversion functions in BluetoothUtils.cpp with those in nsTArrayHelpers.h

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Gabriele Svelto [:gsvelto]]

BluetoothUtils.cpp provides two functions for converting nsTArrays of nsString and BluetoothDevice object references into JSArray objects.

BluetoothDeviceArrayToJSArray could be replaced with the existing nsTArrayToJSArray() function whilst a specialized version of it could be used to replace StringArrayToJSArray().

See bug 739780.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Replace StringArrayToJSArray() and BluetoothDeviceArrayToJSArray() with nsTArrayToJSArray()

I've replaced BluetoothDeviceArrayToJSArray() with a straight call to the existing nsTArrayToJSArray() templated function and added a specialized version of it for nsString to replace StringArrayToJSArray().

Comment 2

[Mozilla RelEng Bot]

Try run for 46ad09c9afaa is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=46ad09c9afaa
Results (out of 1 total builds):
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-46ad09c9afaa

Comment 3

[Gabriele Svelto [:gsvelto]]

Attachment: Replace StringArrayToJSArray() and BluetoothDeviceArrayToJSArray() with nsTArrayToJSArray() V2

Fixed an issue in the previous patch when dealing with strings

Comment 4

[Mozilla RelEng Bot]

Try run for 6cdd419c29b6 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6cdd419c29b6
Results (out of 1 total builds):
    success: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-6cdd419c29b6

Comment 5

[Gabriele Svelto [:gsvelto]]

Comment on attachment 672763 [details] [diff] [review]
Replace StringArrayToJSArray() and BluetoothDeviceArrayToJSArray() with nsTArrayToJSArray() V2

Since I'm unsure if this code is covered by the Android unit tests I've run a few Bluetooth activities on my Otoro with the patch applied to make sure it works correctly and I haven't encountered any obvious problems.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/811bf58c47f2

Also had to push a warnings-as-errors bustage fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee0b7a687708

../../dist/include/nsTArrayHelpers.h: In function 'nsresult nsTArrayToJSArray(JSContext*, const nsTArray<Item, nsTArrayDefaultAllocator>&, JSObject**) [with T = nsString, nsresult = tag_nsresult, JSContext = JSContext, JSObject = JSObject]':
../../dist/include/nsTArrayHelpers.h:64:13: error: unused variable 'global'

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/811bf58c47f2
https://hg.mozilla.org/mozilla-central/rev/ee0b7a687708

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Blocks a blocker.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/abbfdc260d63
https://hg.mozilla.org/releases/mozilla-beta/rev/79257293253b