79816 - duplicates.cgi doesn't work with anything but db files.

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Dawn Endico]

on bugzilla.mozilla.org i've found and patched several problems with
duplicates.cgi. the patched version is at 
http://bugzilla.mozilla.org/duplicates.cgi the original version from cvs is at 
http://bugzilla.mozilla.org/duplicates-orig.cgi


1) the report tries to open a db file so if your installation uses some other
data format you're out of luck. I hard coded in ".dbi" for our installation but
that's obviously not the best solution for everyone.

2) print today's date in the error message when you can't open a db.

3) don't print bugs that are verified or closed. If a bug is so recently fixed
that its not verified yet then It seems likely that there are still people using
a broken build that may want to file a duplicate bug.

4) when sorting by bug number, sort in reverse order. The first 100 low numbered
bugs are of virtually no interest but high numbered bugs are quite interesting.

Comment 1

[Dawn Endico]

Attachment: patch from bugzilla.mozilla.org

Comment 2

[Dawn Endico]

jake points out that my diff is against an old version of duplicates.cgi.
That doesn't make sense. I updated right before i made the changes. oh well.

Comment 3

[Gervase Markham [:gerv]]

Funky! :-)

We now need to get QA to verify some of the older ones on the list, to make it
more useful. I'll do a NG post at some point. And move the www.mozilla.org list
over. No more work for me! ;-)

I'll also integrate the new bits of changes into Bugzilla CVS at some point too.

Gerv

Comment 4

[Dawn Endico]

ok, what happened is that the last time I checked out, I checked out by date so
when i updated it the file it didn't sync to the tip. sigh. I think the db
problem is solved on the tip but I don't think all the other problems are.

Comment 5

[Dawn Endico]

Attachment: new patch that adds strikethrough for resolved bug numbers

Comment 6

[Gervase Markham [:gerv]]

OK, I've extracted the strikethrough part of Dawn's patch, plus a couple of
other tweaks, and am attaching a new patch. Review me, please :-)

Gerv

Comment 7

[Gervase Markham [:gerv]]

Attachment: Strikethrough patch

Comment 8

[Jacob Steenhagen]

The only comment I have is that it seems like using 'eq' instead of a regular
expression '=~' would be a little better when checking the $bug_status variable.
 The only difference I can think of would be performance, and I don't know if
there's a perf difference between 'eq' and '=~'.

Of course, the regular expression method is what's in use at b.m.o right now, so
if you don't wanna change it, that's fine.

r=jake

Comment 9

[Gervase Markham [:gerv]]

Fair point. Any other comments before I redo the patch?

Gerv

Comment 10

[Gervase Markham [:gerv]]

Checked in using "eq" instead of =~.

Gerv

Comment 11

[Dave Miller [:justdave]]

Moving to Bugzilla product