798276 - [keyboard] Numerical keyboard triggering javascript error

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia, defect)

Description

[Etienne Segonzac (:etienne)]

Wonder if other people have seen this:

|Keyboards[_baseLayoutName] is underfined| - line 243.

Every time the numerical keypad should be displayed (phone number field in the contacts app, or typing the |?123| key on the classic keyboard).

Comment 1

[Etienne Segonzac (:etienne)]

Attachment: Fix

Comment 2

[Etienne Segonzac (:etienne)]

Hey Salva, I'm afraid I'm the only one with the issue (I had it for quite some time and couldn't find a bug for it).

I'm testing with an up to date gaia, gecko and gonk, do you see the same problem?

Comment 3

[Salvador de la Puente González [:salva]]

Comment on attachment 668383 [details] [diff] [review]
Fix

Review of attachment 668383 [details] [diff] [review]:
-----------------------------------------------------------------

I dont know if Keyboards[_baseLayoutName] could be undefined and it should be convenient to double check if this is possible at all and if not, trying to discover what causes _baseLayoutName to not be inside Keyboards. I will be on holidays until October 22th so I passed this review to [:rudyl].

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 668383 [details] [diff] [review]
Fix

Review of attachment 668383 [details] [diff] [review]:
-----------------------------------------------------------------

Anyway, I think the patch is an agnostic but valid solution.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Etienne,

Although I did not encounter the case you mentioned, I think the code is ok to merge.
r=me 

Thanks.

Comment 6

[Etienne Segonzac (:etienne)]

Thanks Rudy!
Actually I'm not seeing the issue anymore since my flush reflash from yesterday.

So WORKSFORME now.