798299 - keys trap invariant not enforced

Status: RESOLVED DUPLICATE of bug 1049662

(Core :: JavaScript Engine, defect)

Description

[David Bruant]

From the wiki:
"Check whether all enumerable sealed target properties are listed in the trap result"

However, this test fails:

  var t = {a:1};
  Object.defineProperty(t, 'b', {value: 2, configurable: false, enumerable: false});
  Object.defineProperty(t, 'c', {value: 3, configurable: false, enumerable: true});

  var p = new Proxy(t, {
    getOwnPropertyNames: function(target){
      return ['a', 'b']; // forgetting 'c'. Oops...
    }
  });

  Object.keys(p); // ?

The last call should throw because of 'c' omission, but it doesn't currently in nightly.

Comment 1

[David Bruant]

The invariant is also not enforced for the enumerate trap (but that might be related to bug 783826 ). Make sure the same invariant holds for the enumerate trap when fixing this.

Comment 2

[Tom S. (please needinfo tschuster)]

Not a direct dup, but in spirit.