Closed Bug 798352 Opened 7 years ago Closed 7 years ago

Windows build fails in sctp under VC9 because EALREADY is undefined

Categories

(Core :: Networking, defect, blocker)

x86
Windows 7
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: wgianopoulos, Assigned: wgianopoulos)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

Windows builds using VC9 are failing with:

/netwerk/sctp/datachannel/DataChannel.cpp(605) : error C2065: 'EALREADY' : undeclared identifier
Blocks: 729511
Keywords: regression
Assignee: nobody → rjesup
Attached patch This seems to work for me (obsolete) — Splinter Review
Assignee: rjesup → bill
Status: NEW → ASSIGNED
Attachment #668590 - Flags: review?(ted.mielczarek)
Comment on attachment 668590 [details] [diff] [review]
This seems to work for me

No it doesn't! New patch coming.
Attachment #668590 - Attachment is obsolete: true
Attachment #668590 - Flags: review?(ted.mielczarek)
Attached patch patch v2 (obsolete) — Splinter Review
This one should be better.  I will ask for review if my build works.
Attached patch patch v3Splinter Review
Third time is the charm!
Attachment #668610 - Attachment is obsolete: true
Attachment #668657 - Flags: review?(ted.mielczarek)
Comment on attachment 668657 [details] [diff] [review]
patch v3

Bill - thanks!  Looks good to me.
Attachment #668657 - Flags: review+
Keywords: checkin-needed
I'll check it in
Comment on attachment 668657 [details] [diff] [review]
patch v3

Inbound's hosed, so I went ahead and landed this on m-c directly.

https://hg.mozilla.org/mozilla-central/rev/7194294d8a88
Attachment #668657 - Flags: review?(ted.mielczarek)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.