798413 - Add the ability to export signatures from a libmar file

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

We need a way to export a specific signature from a MAR file.
This should include a way to specify which signature should be exported.
The exported signature should be in a copy/pasteable encoding such as base64.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1 - Implementation for extracting signatures

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1 - Tests for extracting signatures

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1 - Reference base64 encoded files

Comment 4

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2 - Implementation for extracting signatures

- Fixed file handle not being closed after extracting sig
- Synced parameter name/comments
- Fixed a couple typos

Comment 5

[Brian R. Bondy [:bbondy]]

Attachment: Patch v3 - Implementation for extracting signatures

Rebased after multi signing review comments and carried forward similar review comments into this patch.

Comment 6

[Brian R. Bondy [:bbondy]]

Attachment: Patch v4 - Implementation for extracting signatures

Rebased for windows change

Comment 7

[Brian R. Bondy [:bbondy]]

Attachment: Patch v4' - Implementation for extracting signatures

Comment 8

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 671471 [details] [diff] [review]
Patch v4' - Implementation for extracting signatures

Review of attachment 671471 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libmar/sign/mar_sign.c
@@ +507,5 @@
> +    fprintf(stderr, "ERROR: could not open source file: %s\n", src);
> +    goto failure;
> +  }
> +
> +  fpDest = fopen(dest, "wb");

IMO, it is better to just do things the Unix way and output to stdout. If the user wants the output in a file then they can redirect the output.

I suspect people will want to write scripts like:

mar -X0 [...] >> signatures
echo >> signatures
mar -X1 [...] >> signatures
echo >> signatures

Comment 9

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 669651 [details] [diff] [review]
Patch v1 - Tests for extracting signatures

Review of attachment 669651 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libmar/tests/unit/test_sign_verify.js
@@ +325,5 @@
>        let outMARData = getBinaryFileData(outMAR);
>        let originalMARData = getBinaryFileData(originalMAR);
>        compareBinaryData(outMARData, originalMARData);
>      },
> +    // Test extracting the first MAR in a MAR that has only a single signature

s/first MAR/first signature/

Comment 10

[Brian R. Bondy [:bbondy]]

(In reply to Brian Smith (:bsmith) from comment #8)
> Comment on attachment 671471 [details] [diff] [review]
> Patch v4' - Implementation for extracting signatures
> 
> Review of attachment 671471 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: modules/libmar/sign/mar_sign.c
> @@ +507,5 @@
> > +    fprintf(stderr, "ERROR: could not open source file: %s\n", src);
> > +    goto failure;
> > +  }
> > +
> > +  fpDest = fopen(dest, "wb");
> 
> IMO, it is better to just do things the Unix way and output to stdout. If
> the user wants the output in a file then they can redirect the output.
> 
> I suspect people will want to write scripts like:
> 
> mar -X0 [...] >> signatures
> echo >> signatures
> mar -X1 [...] >> signatures
> echo >> signatures

I considered changing this, but there's no point and no advantage since you can just do something like less filename and pipe it wherever you want. 

There's more important things to do.

Comment 11

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2 - Tests for extracting signatures

Fixed comment. Carrying forward r+.

Comment 12

[Brian R. Bondy [:bbondy]]

Attachment: Patch v5 - Implementation for extracting signatures

Small fix to initialize fpSrc and fpDest to NULL which caused intermittent crash on invalid path specified test cases.

Carrying forward r+.

Comment 13

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/mozilla-central/rev/29ee4f3f346b
https://hg.mozilla.org/mozilla-central/rev/b3d74f835aa9
https://hg.mozilla.org/mozilla-central/rev/53560434a236

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6938fbe86e5f
https://hg.mozilla.org/releases/mozilla-aurora/rev/0aff52299302
https://hg.mozilla.org/releases/mozilla-aurora/rev/b850b9082637