spdy enable reading of ping reply

RESOLVED FIXED in Firefox 17

Status

()

Core
Networking: HTTP
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

(Depends on: 1 bug)

16 Branch
mozilla18
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox17 fixed, firefox18 fixed)

Details

(Whiteboard: [spdy][qa?])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I noticed when reading logs for bug 790184 that some idle spdy sessions were failing their keep alive checks when networking appeared to be working fine.

it turns out when we generate a ping sometimes mSocketIn is not set to read data and so the ping reply is queued without being read and eventually the session times out.

This results in tearing down idle sessions more aggressively than we intend to.
(Assignee)

Comment 1

5 years ago
Created attachment 668489 [details] [diff] [review]
patch 0
Attachment #668489 - Flags: review?(honzab.moz)
Comment on attachment 668489 [details] [diff] [review]
patch 0

Review of attachment 668489 [details] [diff] [review]:
-----------------------------------------------------------------

Ooops!  This was really missing!
Attachment #668489 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/39d7c39c6ac2

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/39d7c39c6ac2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
(Assignee)

Comment 5

5 years ago
Comment on attachment 668489 [details] [diff] [review]
patch 0

790184 was r? for FF17, and this patch should go with it to ensure full efficacy. This patch is very low risk.
Attachment #668489 - Flags: approval-mozilla-aurora?

Updated

5 years ago
Attachment #668489 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
(Assignee)

Comment 6

5 years ago
  https://hg.mozilla.org/releases/mozilla-beta/rev/8bc762ccc4ea
status-firefox17: --- → fixed
status-firefox18: --- → fixed
Is there something QA can do here to verify this is fixed?
Whiteboard: [spdy] → [spdy][qa?]

Comment 8

4 years ago
(These dependants were mis-added to bug 798243 due to the wrong bug number being in the commit message)
Depends on: 819044, 823030
You need to log in before you can comment on or make changes to this bug.