Closed
Bug 798423
Opened 12 years ago
Closed 12 years ago
spdy enable reading of ping reply
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: mcmanus, Assigned: mcmanus)
References
Details
(Whiteboard: [spdy][qa?])
Attachments
(1 file)
1.48 KB,
patch
|
mayhemer
:
review+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
I noticed when reading logs for bug 790184 that some idle spdy sessions were failing their keep alive checks when networking appeared to be working fine.
it turns out when we generate a ping sometimes mSocketIn is not set to read data and so the ping reply is queued without being read and eventually the session times out.
This results in tearing down idle sessions more aggressively than we intend to.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #668489 -
Flags: review?(honzab.moz)
Comment 2•12 years ago
|
||
Comment on attachment 668489 [details] [diff] [review]
patch 0
Review of attachment 668489 [details] [diff] [review]:
-----------------------------------------------------------------
Ooops! This was really missing!
Attachment #668489 -
Flags: review?(honzab.moz) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 668489 [details] [diff] [review]
patch 0
790184 was r? for FF17, and this patch should go with it to ensure full efficacy. This patch is very low risk.
Attachment #668489 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #668489 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Assignee | ||
Comment 6•12 years ago
|
||
status-firefox17:
--- → fixed
status-firefox18:
--- → fixed
Is there something QA can do here to verify this is fixed?
Whiteboard: [spdy] → [spdy][qa?]
Comment 8•12 years ago
|
||
(These dependants were mis-added to bug 798243 due to the wrong bug number being in the commit message)
You need to log in
before you can comment on or make changes to this bug.
Description
•