798458 - changes to make minification of GCLI work [patch]

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Grant Gayed]

Attachment: patch

Minification of the Orion page that uses GCLI fails because GCLI has some details that Rhino considers to be errors (although they are valid JS).  We have made the GCLI changes to address this in our local Orion-1.0 pull, and would like to see these changes make it into GCLI's master so that this issue does not have to be addressed every time we pull new GCLI content.

The attached patch contains the changes we've made.  Note that the patch applies to the master branch at https://github.com/mozilla/gcli.git, not to the Orion-1.0 branch.

Comment 1

[Joe Walker [:jwalker]]

Thanks Grant. These changes are on their way.

Another time, please could you use a pull request (to https://github.com/joewalker/gcli/) rather than a bug?
There are 2 advantages of pull requests for me/gcli:
- You can tell a story of how you came to the eventual result
- You can add a 'signed-off by' line, which helps your legal team :)

We use bugzilla as a way to track things getting into Firefox/etc but you care more about getting into GCLI.

Comment 2

[Joe Walker [:jwalker]]

Attachment: v1

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 672386 [details] [diff] [review]
v1

just driving by.

Comment 4

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=6337e18d0024

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a7982bf885b