Closed
Bug 798508
Opened 11 years ago
Closed 11 years ago
Implement an API for opening new windows in private browsing
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 19
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(2 files)
5.13 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
3.64 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
The goal is to implement the following feature: window.openDialog("chrome://browser/content/", "_blank", "chrome,private");
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to Ehsan Akhgari [:ehsan] from comment #0) > The goal is to implement the following feature: > > window.openDialog("chrome://browser/content/", "_blank", "chrome,private"); Oh, and also: OpenBrowserWindow({private: true}) in browser.js.
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #668944 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Comment on attachment 668945 [details] [diff] [review] Part 2 Review of attachment 668945 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/browser.js @@ +3519,4 @@ > var defaultArgs = handler.defaultArgs; > var wintype = document.documentElement.getAttribute('windowtype'); > > + var extraFeatures = ''; Why single quotes, when you use double below? @@ +3522,5 @@ > + var extraFeatures = ''; > +#ifdef MOZ_PER_WINDOW_PRIVATE_BROWSING > + if (typeof options == "object" && > + "private" in options && > + !!options.private) { No need for the !!
Comment 6•11 years ago
|
||
Comment on attachment 668945 [details] [diff] [review] Part 2 Review of attachment 668945 [details] [diff] [review]: ----------------------------------------------------------------- r=me with Ms2ger's nits addressed.
Attachment #668945 -
Flags: review?(josh) → review+
![]() |
||
Comment 7•11 years ago
|
||
Comment on attachment 668944 [details] [diff] [review] Part 1 r=me
Attachment #668944 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/099477f00862 https://hg.mozilla.org/integration/mozilla-inbound/rev/718453ec2c8a
Target Milestone: --- → Firefox 19
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/099477f00862 https://hg.mozilla.org/mozilla-central/rev/718453ec2c8a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 10•11 years ago
|
||
Changes like this (to a widely-used "core" browser API) should generally get some form of review or signoff from a browser peer, in the future.
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #10) > Changes like this (to a widely-used "core" browser API) should generally get > some form of review or signoff from a browser peer, in the future. Sorry! Is there anything that you would like to see changed in this API? I'd be glad to make any changes that you think would be appropriate.
Comment 12•11 years ago
|
||
No, I think the end result is fine (bug 822056 is what brought this to my attention, but that's a minor style thing, not a big deal).
You need to log in
before you can comment on or make changes to this bug.
Description
•