798508 - Implement an API for opening new windows in private browsing

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

The goal is to implement the following feature:

window.openDialog("chrome://browser/content/", "_blank", "chrome,private");

Comment 1

[John Schoenick [:johns]]

Ack, un-warned collision :(

Comment 2

[(no longer active)]

(In reply to Ehsan Akhgari [:ehsan] from comment #0)
> The goal is to implement the following feature:
> 
> window.openDialog("chrome://browser/content/", "_blank", "chrome,private");

Oh, and also: OpenBrowserWindow({private: true}) in browser.js.

Comment 3

[(no longer active)]

Attachment: Part 1

Comment 4

[(no longer active)]

Attachment: Part 2

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 668945 [details] [diff] [review]
Part 2

Review of attachment 668945 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser.js
@@ +3519,4 @@
>    var defaultArgs = handler.defaultArgs;
>    var wintype = document.documentElement.getAttribute('windowtype');
>  
> +  var extraFeatures = '';

Why single quotes, when you use double below?

@@ +3522,5 @@
> +  var extraFeatures = '';
> +#ifdef MOZ_PER_WINDOW_PRIVATE_BROWSING
> +  if (typeof options == "object" &&
> +      "private" in options &&
> +      !!options.private) {

No need for the !!

Comment 6

[Josh Matthews [:jdm]]

Comment on attachment 668945 [details] [diff] [review]
Part 2

Review of attachment 668945 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with Ms2ger's nits addressed.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 668944 [details] [diff] [review]
Part 1

r=me

Comment 8

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/099477f00862
https://hg.mozilla.org/integration/mozilla-inbound/rev/718453ec2c8a

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/099477f00862
https://hg.mozilla.org/mozilla-central/rev/718453ec2c8a

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Changes like this (to a widely-used "core" browser API) should generally get some form of review or signoff from a browser peer, in the future.

Comment 11

[(no longer active)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #10)
> Changes like this (to a widely-used "core" browser API) should generally get
> some form of review or signoff from a browser peer, in the future.

Sorry!

Is there anything that you would like to see changed in this API?  I'd be glad to make any changes that you think would be appropriate.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

No, I think the end result is fine (bug 822056 is what brought this to my attention, but that's a minor style thing, not a big deal).