Closed Bug 798516 Opened 7 years ago Closed 7 years ago

Remove support for gPrivateBrowsingUI.privateWindow

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 19

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

PrivateBrowsingUtils.isWindowPrivate is a better API.
Attached patch Patch (v1)Splinter Review
Attachment #668661 - Flags: review?(josh)
Comment on attachment 668661 [details] [diff] [review]
Patch (v1)

Review of attachment 668661 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js
@@ +29,4 @@
>          executeSoon(function() {
>            let ui = aSubject.gPrivateBrowsingUI;
>            is(ui.privateBrowsingEnabled, expected, "The privateBrowsingEnabled property on the new window is set correctly");
> +          is(PrivateBrowsingUtils.isWindowPrivate(window), expected, "The private bit on the new window is set correctly");

This should be aSubject
Attachment #668661 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/479174108809
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.