798516 - Remove support for gPrivateBrowsingUI.privateWindow

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

PrivateBrowsingUtils.isWindowPrivate is a better API.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=7941b1646552

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 668661 [details] [diff] [review]
Patch (v1)

Review of attachment 668661 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js
@@ +29,4 @@
>          executeSoon(function() {
>            let ui = aSubject.gPrivateBrowsingUI;
>            is(ui.privateBrowsingEnabled, expected, "The privateBrowsingEnabled property on the new window is set correctly");
> +          is(PrivateBrowsingUtils.isWindowPrivate(window), expected, "The private bit on the new window is set correctly");

This should be aSubject

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/479174108809

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/479174108809