79852 - Lots of JS warnings doing address book operations

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Simon Fraser [no longer active]]

I'm seeing JS errors up the wazoo when doing stuff in the address book:

* Drag card from 'Collected addresses' to 'Personal Address book' gives:

BeginDragResultTree

selArray.length = 1

    ID #0 = abmdbcard://history.mab/Card74

DropOnTree

***targetID = abmdbdirectory://abook.mab

    Node #0: drop 'abmdbcard://history.mab/Card74' on 'abmdbdirectory://
abook.mab'


###!!! ASSERTION: 
XPConnect is being called on a scope without a 'Components' property!

This is pretty much always bad. It usually means that native code is
making a callback to an interface implemented in JavaScript, but the
document where the JS object was created has already been cleared and the
global properties of that document's window are *gone*. Generally this
indicates a problem that should be addressed in the design and use of the
callback code.
: 'Error', file xpcwrappednativescope.cpp, line 515
###!!! ASSERTION: 
XPConnect is being called on a scope without a 'Components' property!

This is pretty much always bad. It usually means that native code is
making a callback to an interface implemented in JavaScript, but the
document where the JS object was created has already been cleared and the
global properties of that document's window are *gone*. Generally this
indicates a problem that should be addressed in the design and use of the
callback code.
: 'Error', file xpcwrappednativescope.cpp, line 515
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[JavaScript Error: "UpdateAddDeleteCounts is not defined" {file: 
"chrome://messenger/content/addressbook/addressbook.js" line: 11}] 
[nsIAbListener::onItemAdded]"  nsresult: "0x80570021 
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://
messenger/content/addressbook/abDragDrop.js :: DropOnDirectoryTree :: line 220"  
data: yes]
************************************************************


* Delete card in personal address book (using delete key) gives:

###!!! ASSERTION: 
XPConnect is being called on a scope without a 'Components' property!

This is pretty much always bad. It usually means that native code is
making a callback to an interface implemented in JavaScript, but the
document where the JS object was created has already been cleared and the
global properties of that document's window are *gone*. Generally this
indicates a problem that should be addressed in the design and use of the
callback code.
: 'Error', file xpcwrappednativescope.cpp, line 515
###!!! ASSERTION: 
XPConnect is being called on a scope without a 'Components' property!

This is pretty much always bad. It usually means that native code is
making a callback to an interface implemented in JavaScript, but the
document where the JS object was created has already been cleared and the
global properties of that document's window are *gone*. Generally this
indicates a problem that should be addressed in the design and use of the
callback code.
: 'Error', file xpcwrappednativescope.cpp, line 515
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[JavaScript Error: "UpdateAddDeleteCounts is not defined" {file: 
"chrome://messenger/content/addressbook/addressbook.js" line: 14}] 
[nsIAbListener::onItemRemoved]"  nsresult: "0x80570021 
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://
messenger/content/addressbook/abCommon.js :: anonymous :: line 56"  data: yes]
************************************************************

Comment 1

[John Marmion]

I am seeing very similar messages on both Linux and Windows Debug Builds against
the Head today and yesterday. Here is the text of waht I am seeing:

/* Delete a Card ...
XPconnect is being called on a scope without a 'Components' property!

This is pretty much always bad. It usually means that native code is
making a callback to an interface implemented in JavaScript, but the
document where the JS object was created has already been cleared and the
global properties of that document's window are *gone*. Generally this
indicates a problem that should be addressed in the design and use of the
callback code.
: 'Error', file xpcwrappednativescope.cpp, line 515
###!!! Break: at file xpcwrappednativescope.cpp, line 515
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "UpdateAddDeleteCounts is not defined" {file:
"chrome://messenger/content/addressbook/addressbook.js" line: 14}]' when calling
method: [nsIAbListener::onItemRemoved]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
chrome://messenger/content/addressbook/abCommon.js :: anonymous :: line 56" 
data: yes]


/* Drag n Drop a Card ...
XPConnect is being called on a scope without a 'Components' property!

This is pretty much always bad. It usually means that native code is
making a callback to an interface implemented in JavaScript, but the
document where the JS object was created has already been cleared and the
global properties of that document's window are *gone*. Generally this
indicates a problem that should be addressed in the design and use of the
callback code.
: 'Error', file xpcwrappednativescope.cpp, line 515
###!!! Break: at file xpcwrappednativescope.cpp, line 515
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "UpdateAddDeleteCounts is not defined" {file:
"chrome://messenger/content/addressbook/addressbook.js" line: 11}]' when calling
method: [nsIAbListener::onItemAdded]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
chrome://messenger/content/addressbook/abDragDrop.js :: DropOnDirectoryTree ::
line 203"  data: yes]



To re-create every time:

1. start mozilla [with no options]
2. Choose the Address Book from the Task list
3. Do some activity i.e. D'n'D, Delete etc...
4. Close The Address Book
5. Choose the Address Book again from the Task List
6. Attempt to Delete or Drag'n'Drop will result in the above error.   

Comment 2

[chuang]

This may related to bug 82991.  Can either one of you try the patch in 82991 and 
see if it fix it?   I never see this assertion and maybe because I have the fix 
on my tree.

Comment 3

[John Marmion]

I have tried #82991 but I am still seeing the problem. We had a closer look 
at it here and it appears that the function 'OnUnloadAddressBook' in
addressbook.js is not being called from the corresponding xul addressbook.xul
file when the 'Address Book' is closed.

Comment 4

[chuang]

I tried on John's steps with or without the 82991 patch,  I didn't get the 
assertion on Win2000 using my debug tree updated yesterday.

Comment 5

[chuang]

Attachment: Patch for fix

Comment 6

[chuang]

One extra ">" in addressbook.xul to cause this problem.

Comment 7

[Simon Fraser [no longer active]]

r/sr=sfraser. Should move to 0.9.2, I think.

Comment 8

[chuang]

Trying to get into 0.9.2 and PDT+.

Comment 9

[scottputterman]

moving to 0.9.2.  I will get the PDT+ on this.

Comment 10

[selmer (gone)]

PDT approved for 092, please get the other review and drivers approval

Comment 11

[Asa Dotzler [:asa]]

This still needs a second review. When it has that review it is approved for
checkin.

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 12

[Scott MacGregor]

sr=mscott

Comment 13

[chuang]

fix checked in

Comment 14

[fenella]

Candice, where do you see the error message on Mac? I thought Mac does not
provide any console window.

Comment 15

[chuang]

I saw it on Windows,  not on Mac.

Comment 16

[Simon Fraser [no longer active]]

Mac only has a console in debug builds.

Comment 17

[fenella]

Thanks, Candice.
OK. This bug fixed on win32 (2001-06-19-11 trunk)