798764 - Global console: add support for a global ConsoleProgressListener

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Mihai Sucan [:msucan]]

The ConsoleProgressListener gives us location changes and file URI loads. This code should also work with the global console actor.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: proposed fix

This patch fixes the ConsoleProgressListener such that we can use it with the global consoleActor. This patch also fixes the WebConsoleActor constructor such that it works with the b2g tab.

When you attach to the tab consoleActor on b2g you do not receive any message. Window IDs are not matching, network requests fail to give the associatedWindow and so on. For now, only the global consoleActor is useful.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 670750 [details] [diff] [review]
proposed fix

Review of attachment 670750 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/webconsole/NetworkHelper.jsm
@@ +213,5 @@
>    getWindowForRequest: function NH_getWindowForRequest(aRequest)
>    {
> +    try {
> +      return this.getRequestLoadContext(aRequest).associatedWindow;
> +    } catch (ex) { }

This pattern seems worrisome, but I see you have been using it in this file before this patch, so OK.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Mihai Sucan [:msucan] from comment #1)
> When you attach to the tab consoleActor on b2g you do not receive any
> message. Window IDs are not matching, network requests fail to give the
> associatedWindow and so on. For now, only the global consoleActor is useful.

What is the plan for getting the tab consoleActor working?

Comment 4

[Mihai Sucan [:msucan]]

(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 670750 [details] [diff] [review]
> proposed fix
> 
> Review of attachment 670750 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/devtools/webconsole/NetworkHelper.jsm
> @@ +213,5 @@
> >    getWindowForRequest: function NH_getWindowForRequest(aRequest)
> >    {
> > +    try {
> > +      return this.getRequestLoadContext(aRequest).associatedWindow;
> > +    } catch (ex) { }
> 
> This pattern seems worrisome, but I see you have been using it in this file
> before this patch, so OK.

Indeed, this is really dated code, I just followed the same pattern.


(In reply to Panos Astithas [:past] from comment #3)
> (In reply to Mihai Sucan [:msucan] from comment #1)
> > When you attach to the tab consoleActor on b2g you do not receive any
> > message. Window IDs are not matching, network requests fail to give the
> > associatedWindow and so on. For now, only the global consoleActor is useful.
> 
> What is the plan for getting the tab consoleActor working?

We need to file a separate bug report about that. In B2G we want not tabs, but separation between apps and Firefox browser tabs support - if I am not mistaken. A working single-tab parent for the whole B2G won't help with anything - it would still give us all network request and errors that happen B2G - very much like the global consoleActor. It would be a lot more useful if we could select the app or the Firefox tab browser to monitor.

In either case, we *probably* need additional platform support - for example the associatedWindow property for network requests is not readable.

I wonder if we want to expose the tab consoleActor at this point on B2G? I don't know how far off we are from being able to separate errors, network requests, etc, coming from different apps.


Thanks for the review!

Comment 5

[Mihai Sucan [:msucan]]

Attachment: test fix

Had a failure in try runs. Test fixed.

Green try run:
https://tbpl.mozilla.org/?tree=Try&rev=1da4d4ccabf6

Comment 6

[Mihai Sucan [:msucan]]

Landed:
https://hg.mozilla.org/integration/fx-team/rev/7d2e011a7b9f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7d2e011a7b9f