798859 - java.lang.NoSuchMethodError: java.lang.String.isEmpty at org.mozilla.gecko.AllPagesTab.filter(AllPagesTab.java)

Status: RESOLVED FIXED

(Firefox for Android :: General, defect, critical)

Description

[Scoobidiver (away)]

There are 3 crashes from the same user in 18.0a1/20121006134717: bp-ffcda692-83db-420e-9843-59f3c2121007.

java.lang.NoSuchMethodError: java.lang.String.isEmpty
	at org.mozilla.gecko.AllPagesTab.filter(AllPagesTab.java:149)
	at org.mozilla.gecko.AwesomeBarTabs.filter(AwesomeBarTabs.java:218)
	at org.mozilla.gecko.AwesomeBar$4.afterTextChanged(AwesomeBar.java:167)
	at android.widget.TextView.sendAfterTextChanged(TextView.java:6254)
	at android.widget.TextView$ChangeWatcher.afterTextChanged(TextView.java:6437)
	at android.text.SpannableStringBuilder.sendTextHasChanged(SpannableStringBuilder.java:897)
	at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:503)
	at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:409)
	at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:28)
	at android.view.inputmethod.BaseInputConnection.replaceText(BaseInputConnection.java:583)
	at android.view.inputmethod.BaseInputConnection.commitText(BaseInputConnection.java:174)
	at com.android.internal.widget.EditableInputConnection.commitText(EditableInputConnection.java:120)
	at com.android.internal.view.IInputConnectionWrapper.executeMessage(IInputConnectionWrapper.java:257)
	at com.android.internal.view.IInputConnectionWrapper$MyHandler.handleMessage(IInputConnectionWrapper.java:77)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:123)
	at android.app.ActivityThread.main(ActivityThread.java:4627)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:521)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:858)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NoSuchMethodError%3A+java.lang.String.isEmpty+at+org.mozilla.gecko.AllPagesTab.filter%28AllPagesTab.java%29

Comment 1

[Scoobidiver (away)]

It has been hit by another user. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2da1f2bde40e&tochange=9f677c2bb33d
It's likely a regression from bug 769145.

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Remove isEmpty() call in AllPagesTab

I forgot that String.isEmpty() wasn't introduced in Android until API level 9.

Comment 3

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/117da9598f32

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/117da9598f32