Closed
Bug 799000
Opened 13 years ago
Closed 13 years ago
Don't double count when memory-reporting for JSObject2WrappedJSMap
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
1.60 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
DMD tells me that bug 772292 introduced double-counting of |mTable| in
JSObject2WrappedJSMap::SizeOfIncludingThis(). It's an easy fix.
|
Assignee | |
Comment 1•13 years ago
|
||
Patch. I also fixed a compile warning about a mixed signed/unsigned
comparison nearby.
Attachment #669001 -
Flags: review?(terrence)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Nb: note the change from "Including" to "Excluding", which is easy to miss.
|
||
Comment 3•13 years ago
|
||
Comment on attachment 669001 [details] [diff] [review]
Don't double count when memory-reporting for JSObject2WrappedJSMap.
Review of attachment 669001 [details] [diff] [review]:
-----------------------------------------------------------------
Doh!
Attachment #669001 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•