Closed Bug 799015 Opened 13 years ago Closed 13 years ago

Use correct syntax for findClass() in JNI

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox18 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 19
Tracking Flags:
Tracking Status
firefox18 --- fixed

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

Use correct syntax for findClass() in JNI
1.47 KB, patch
wesj
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
The delimiter for findClass() in JNI should be a "/", not a ".". For example, see findClass() usages at http://mxr.mozilla.org/mozilla-central/source/widget/android/AndroidBridge.cpp#177
Attachment #669023 - Flags: review?(wjohnston)
Comment on attachment 669023 [details] [diff] [review] Use correct syntax for findClass() in JNI Not sure why I did that.... thanks!
Attachment #669023 - Flags: review?(wjohnston) → review+
We'll need to uplift this to Fx18 on Aurora
status-firefox18: --- → affected
Comment on attachment 669023 [details] [diff] [review] Use correct syntax for findClass() in JNI [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 787271 User impact if declined: getting icon size may not work on some devices Testing completed (on m-c, etc.): m-i Risk to taking this patch (and alternatives if risky): low risk String or UUID changes made by this patch: none
Attachment #669023 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/3c12b65a382d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Attachment #669023 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: