Closed Bug 799105 Opened 7 years ago Closed 7 years ago

several of the reftests/text tests have resolutions > 600x600

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 2 obsolete files)

We are working on fixing the reftests so they have a resolution < 600x600.  We have a list of the tests up here:
http://people.mozilla.com/~ahalberstadt/reftest/600x600_tests_to_fix.json

We just need to adjust those tests to fit in a 600x600 window.
Summary: serveral of the reftests/text tests have resolutions > 600x600 → several of the reftests/text tests have resolutions > 600x600
this fixes one test failure from the original patch :Mavericks uploaded.
Assignee: nobody → jmaher
Attachment #670777 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #671438 - Flags: review?(smontagu)
Comment on attachment 671438 [details] [diff] [review]
udpate the layout/reftests/text files to fit in 600x600 pixels (1.0)

Review of attachment 671438 [details] [diff] [review]:
-----------------------------------------------------------------

Has anyone gone through and checked that all these tests still test what they are supposed to be testing after the change?
this is why we are asking for review from somebody who knows more about this area than we do.  I honestly have no idea.  If there is somebody else who should do the review, please redirect.
That's OK, I was just trying to understand the scope of the review request :)
Comment on attachment 671438 [details] [diff] [review]
udpate the layout/reftests/text files to fit in 600x600 pixels (1.0)

Review of attachment 671438 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/text/text-align-default-last-default.html
@@ +5,4 @@
>    <meta charset="utf-8">
>   </head>
>   <body>
> + <p style="margin-right:310px;">Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis odio est, cursus non adipiscing at, fringilla quis eros. Sed volutpat nibh sit amet ante molestie a vehicula nulla gravida. Mauris elementum cursus urna id vestibulum. Etiam volutpat odio tincidunt libero ullamcorper elementum. Suspendisse potenti. Ut ut arcu lorem. Integer mi sapien, porta a pharetra et, varius laoreet eros.  Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Sed ut mi at elit consequat aliquam id eu lectus. Etiam tincidunt diam et ante ullamcorper a convallis erat lobortis. Sed blandit ultrices dui et bibendum. Sed condimentum velit eget nibh rutrum cursus. Quisque pretium iaculis gravida. Proin risus eros, iaculis quis fermentum a, adipiscing&nbsp;id&nbsp;mauris.</p>

Do this by adding a <style> element like the other text-align tests, not inline style.

::: layout/reftests/text/text-align-start-last-start.html
@@ +11,5 @@
>     }
>    </style>
>   </head>
>   <body>
> + <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis odio est, cursus non adipiscing at, fringilla quis eros. Sed volutpat nibh sit amet ante molestie a vehicula nulla gravida. Mauris elementum cursus urna id vestibulum. Etiam volutpat odio tincidunt libero ullamcorper elementum. Suspendisse potenti. Ut ut arcu lorem. Integer mi sapien, porta a pharetra et, varius laoreet eros.  Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Sed ut mi at elit consequat aliquam id eu lectus. Etiam tincidunt diam et ante ullamcorper a convallis erat lobortis. Sed blandit ultrices dui et bibendum. Sed condimentum velit eget nibh rutrum cursus. Quisque pretium iaculis gravida. Proin risus eros, iaculis quis fermentum a, adipiscing&nbsp;id&nbsp;mauris.</p>

Don't make this whitespace change unless there's a good reason for it.
Attachment #671438 - Flags: review?(smontagu) → review+
Addresses  the nits in last comment
Attachment #671438 - Attachment is obsolete: true
Attachment #674220 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/e12cf7513bff
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.