799191 - crash in mozilla::MediaDevice::MediaDevice when clicking the "video" button on anant's gum test page

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Jason Smith [:jsmith]]

This bug was filed from the Socorro interface and is 
report bp-5293ec1f-25b8-4d00-9da3-c15972121008 .
============================================================= 

Dao just got this crash upon testing bug 729522. He's hitting a crash immediately upon selecting "video" in anant's gum test page.

0 	xul.dll 	nsRefPtr<nsCSSKeyframeStyleDeclaration>::assign_with_AddRef 	obj-firefox/dist/include/mozilla/StaticPtr.h:138
1 	xul.dll 	mozilla::MediaDevice::MediaDevice 	dom/media/MediaManager.h:133
2 	xul.dll 	mozilla::GetUserMediaDevicesRunnable::Run 	dom/media/MediaManager.cpp:566
3 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:612
4 	xul.dll 	nsThread::ThreadFunc 	xpcom/threads/nsThread.cpp:256
5 	nspr4.dll 	_PR_NativeRunThread 	nsprpub/pr/src/threads/combined/pruthr.c:395
6 	nspr4.dll 	pr_root 	nsprpub/pr/src/md/windows/w95thred.c:90
7 	msvcr100.dll 	_callthreadstartex 	f:\dd\vctools\crt_bld\self_x86\crt\src\threadex.c:314
8 	msvcr100.dll 	_threadstartex 	f:\dd\vctools\crt_bld\self_x86\crt\src\threadex.c:292
9 	kernel32.dll 	BaseThreadInitThunk 	
10 	ntdll.dll 	__RtlUserThreadStart 	
11 	ntdll.dll 	_RtlUserThreadStart

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Jason Smith [:jsmith] from comment #0)
> immediately upon selecting "video" in anant's gum test page.

Mind telling us where we can find this page?

Comment 2

[Jason Smith [:jsmith]]

(In reply to Henrik Skupin (:whimboo) from comment #1)
> (In reply to Jason Smith [:jsmith] from comment #0)
> > immediately upon selecting "video" in anant's gum test page.
> 
> Mind telling us where we can find this page?

https://people.mozilla.com/~anarayanan/gum_test.html

Comment 3

[Jason Smith [:jsmith]]

I was also able to reproduce this crash, although not consistently.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

This is the bug:

audioCount = videoSources.Length();

:-)

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: incorrect audioCount in GetUserMediaDevicesRunnable

Comment 6

[Timothy B. Terriberry (:derf)]

Comment on attachment 669568 [details] [diff] [review]
incorrect audioCount in GetUserMediaDevicesRunnable

Review of attachment 669568 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e021104715a

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

We should uplift this to Aurora ASAP

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1e021104715a

Comment 10

[Jason Smith [:jsmith]]

Verified on Nightly 10/12.

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 669568 [details] [diff] [review]
incorrect audioCount in GetUserMediaDevicesRunnable

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 752352
User impact if declined: Frequent crashes using mozGetUserMedia
Testing completed (on m-c, etc.): yes, by jsmith
Risk to taking this patch (and alternatives if risky): No risk
String or UUID changes made by this patch: None

Comment 12

[Scoobidiver (away)]

Pushed to Aurora:
http://hg.mozilla.org/releases/mozilla-aurora/rev/bee211decb2d

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bee211decb2d

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Not sure if we can get a crashtest here. Dao, was you ever able to reproduce it? I don't see a crash with an Aurora build from Friday before the patch landed.

Comment 15

[Jason Smith [:jsmith]]

Minusing for testsuite - What could possibly be covered by automation will be covered in bug 781534.