Closed Bug 799199 Opened 8 years ago Closed 8 years ago

Use IndentBy() instead of looped "fputs" in ns*Frame::List methods

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

There are a few places in layout code where we have something like
>  for (int32_t i = aIndent; --i >= 0; ) fputs("  ", out);   // Indent

but we generally use the utility method nsFrame::IndentBy() to accomplish this in one centralized implementation.  I suspect the hardcoded-fputs-loops predate IndentBy(), and they were never switched over.

Filing this bug on replacing the fputs-loops with IndentBy() calls.
Attached patch fixSplinter Review
Attachment #669231 - Flags: review?(bzbarsky)
Comment on attachment 669231 [details] [diff] [review]
fix

r=me
Attachment #669231 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/b177c32d57d6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.