If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use IndentBy() instead of looped "fputs" in ns*Frame::List methods

RESOLVED FIXED in mozilla19

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There are a few places in layout code where we have something like
>  for (int32_t i = aIndent; --i >= 0; ) fputs("  ", out);   // Indent

but we generally use the utility method nsFrame::IndentBy() to accomplish this in one centralized implementation.  I suspect the hardcoded-fputs-loops predate IndentBy(), and they were never switched over.

Filing this bug on replacing the fputs-loops with IndentBy() calls.
(Assignee)

Comment 1

5 years ago
Created attachment 669231 [details] [diff] [review]
fix
Attachment #669231 - Flags: review?(bzbarsky)
Comment on attachment 669231 [details] [diff] [review]
fix

r=me
Attachment #669231 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b177c32d57d6

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/b177c32d57d6
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.