79925 - Redundant popupset in bookmarks sidebar panel makes context menu not work

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Fabian is seeing this (but I'm not), but the popupset is redundant anyhow and 
there could be other cruft in my tree that's preventing me from seeing the bug. 
Attaching a patch to remove the old popupset.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch to remove redundant popupset

Comment 2

[Dan Rosen]

r=dr

Comment 3

[Fabian Guisset]

yep fine
i'll ask on IRC later whether anyone can reproduce the strangeness I'm seeing
with the sidebar/ptoolbar context menus

Comment 4

[R.K.Aa.]

Linux:
I built with this patch: it didn't change anything. None of the context menu
items in sidebar bookmark tab work. The only thing this patch seemed to cause
was that context-menu randomly appeared in the middle of browser instead of near
the bookmark where i clicked.

Comment 5

[Fabian Guisset]

this is just to remove useless code, it will not fix anything.
There is no more popupset called "popupset" so it should not away.
Again this will not fix anything.

Comment 6

[Alec Flett]

sr=alecf on the patch (even if it doesn't fix the bug)

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Easy. 

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Oops, this has been checked in. At least, the popupset isn't in bm-panel.xul
anymore...

Comment 9

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]