Closed Bug 799262 Opened 7 years ago Closed 7 years ago

Better mach API for command/module loading

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla19

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch APIs for loading modules, v1 (obsolete) — Splinter Review
This is a follow-up from bug 794509.

This patch adds a formal API for loading mach command modules. We no longer have the default behavior of always scanning sys.path all the time. Instead, consumers of mach are free to choose how modules are loaded. They could scan sys.path. They could scan individual directories. It's all possible now.

There is still room to grow. For example, we may not want to actually import the module into sys.modules. But, unless you have a better idea, I'm content with keeping it the way it is.
Attachment #669302 - Flags: review?(jhammel)
Now with "load a file" API. Eventually we'll probably have "load from class." But, this is a good stopping point.
Assignee: nobody → gps
Attachment #669302 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #669302 - Flags: review?(jhammel)
Attachment #669324 - Flags: review?(jhammel)
Blocks: 799291
Blocks: 799308
Comment on attachment 669324 [details] [diff] [review]
APIs for loading modules, v2

This wfm.  If we're going for a true plugin architecture we should probably start documenting what we intend and start filing bugs
Attachment #669324 - Flags: review?(jhammel) → review+
https://hg.mozilla.org/mozilla-central/rev/2a0e2af364bc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.