Better mach API for command/module loading

RESOLVED FIXED in mozilla19

Status

Firefox Build System
Mach Core
RESOLVED FIXED
6 years ago
3 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

Trunk
mozilla19
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 669302 [details] [diff] [review]
APIs for loading modules, v1

This is a follow-up from bug 794509.

This patch adds a formal API for loading mach command modules. We no longer have the default behavior of always scanning sys.path all the time. Instead, consumers of mach are free to choose how modules are loaded. They could scan sys.path. They could scan individual directories. It's all possible now.

There is still room to grow. For example, we may not want to actually import the module into sys.modules. But, unless you have a better idea, I'm content with keeping it the way it is.
Attachment #669302 - Flags: review?(jhammel)
(Assignee)

Comment 1

6 years ago
Created attachment 669324 [details] [diff] [review]
APIs for loading modules, v2

Now with "load a file" API. Eventually we'll probably have "load from class." But, this is a good stopping point.
Assignee: nobody → gps
Attachment #669302 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #669302 - Flags: review?(jhammel)
Attachment #669324 - Flags: review?(jhammel)
(Assignee)

Updated

6 years ago
Blocks: 799291
(Assignee)

Updated

6 years ago
Blocks: 799308

Comment 2

6 years ago
Comment on attachment 669324 [details] [diff] [review]
APIs for loading modules, v2

This wfm.  If we're going for a true plugin architecture we should probably start documenting what we intend and start filing bugs
Attachment #669324 - Flags: review?(jhammel) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/2a0e2af364bc
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.