799268 - Remove Permission.txt

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Martijn Wargers (dead)]

I couldn't find 'idle' in the Permission.txt file.

But if I understand the source code, correctly, it is checking for an 'idle' permission.
http://mxr.mozilla.org/mozilla-central/source/dom/base/Navigator.cpp#675

So 'idle' should be added to the Permission.txt list, right?

Comment 1

[Martijn Wargers (dead)]

Attachment: patch

Hrm, there is a lot more in extensions/cookie/Permission.txt that's not there, that is there in dom/apps/src/PermissionsTable.jsm .
Even the doc at https://developer.mozilla.org/en-US/docs/Web/Apps/App_permissions seems to have more info.

Is this Permission.txt still useful?

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 751515 [details] [diff] [review]
patch

Review of attachment 751515 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, I do not think this file is very useful. I would definitely r+ a patch that removes it.

Comment 3

[Martijn Wargers (dead)]

Attachment: git patch

Ok, let's do that then.

Comment 4

[Mounir Lamouri (:mounir)]

Comment on attachment 751636 [details] [diff] [review]
git patch

Review of attachment 751636 [details] [diff] [review]:
-----------------------------------------------------------------

Asking Gregor to review that change to in case of this file has a role I wasn't aware of.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd2ffe93fb2f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dd2ffe93fb2f