799272 - [jsdbg2] Debugger.Object should provide a way to get the global, and to unwrap

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Jim Blandy :jimb]

There should be a way to find the global in whose scope an object was allocated; and to unwrap Debugger.Object instances referring to wrappers, when security permits. Together these operations will let debuggers make better sense of their referent's wrapper and compartment structure.

Draft spec:
https://github.com/jimblandy/DebuggerDocs/compare/wrapper-inspection

Comment 1

[Jim Blandy :jimb]

Attachment: Implement Debugger.Object.prototype.global.

Comment 2

[Jim Blandy :jimb]

Attachment: Implement Debugger.Object.prototype.unwrap.

Comment 3

[Jim Blandy :jimb]

Try: https://tbpl.mozilla.org/?tree=Try&rev=83d6ae92cfbc

Will request reviews when this looks good.

Comment 4

[Luke Wagner [:luke]]

Comment on attachment 669631 [details] [diff] [review]
Implement Debugger.Object.prototype.global.

Stealing at jimb's request.

Makes sense.  Good tests.

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 669632 [details] [diff] [review]
Implement Debugger.Object.prototype.unwrap.

Ditto.

On irc I asked about, generally, whether it is an error to have a Debugger.Object to an object in a non-debuggee global.  The answer was "we tolerate that".  I guess if we ever decided not to do that, makeDebuggeeValue would be pinch-point to change.

Comment 6

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/mozilla-inbound/rev/708db1ae8d66
https://hg.mozilla.org/integration/mozilla-inbound/rev/147285c88028

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/708db1ae8d66
https://hg.mozilla.org/mozilla-central/rev/147285c88028