Closed Bug 799272 Opened 9 years ago Closed 9 years ago

[jsdbg2] Debugger.Object should provide a way to get the global, and to unwrap

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 19

People

(Reporter: jimb, Assigned: jimb)

References

Details

Attachments

(2 files)

There should be a way to find the global in whose scope an object was allocated; and to unwrap Debugger.Object instances referring to wrappers, when security permits. Together these operations will let debuggers make better sense of their referent's wrapper and compartment structure.

Draft spec:
https://github.com/jimblandy/DebuggerDocs/compare/wrapper-inspection
Try: https://tbpl.mozilla.org/?tree=Try&rev=83d6ae92cfbc

Will request reviews when this looks good.
Blocks: 796073
Blocks: 743311
Attachment #669631 - Flags: review?(jorendorff)
Attachment #669632 - Flags: review?(jorendorff)
Comment on attachment 669631 [details] [diff] [review]
Implement Debugger.Object.prototype.global.

Stealing at jimb's request.

Makes sense.  Good tests.
Attachment #669631 - Flags: review?(jorendorff) → review+
Comment on attachment 669632 [details] [diff] [review]
Implement Debugger.Object.prototype.unwrap.

Ditto.

On irc I asked about, generally, whether it is an error to have a Debugger.Object to an object in a non-debuggee global.  The answer was "we tolerate that".  I guess if we ever decided not to do that, makeDebuggeeValue would be pinch-point to change.
Attachment #669632 - Flags: review?(jorendorff) → review+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.