799314 - Add utility method to PrivateBrowsingUtils to obtain nsILoadContext from window

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Josh Matthews [:jdm]]

Writing up docs for the bug 722872 fiasco, I realized that it sucks to be telling developers how to obtain an nsILoadContext. We should add a GetPrivacyContext method to PrivateBrowsingUtils and get it into FF17.

Comment 1

[(no longer active)]

Makes sense.

Comment 2

[Josh Matthews [:jdm]]

Attachment: Add utility method to get a privacy context from a window.

Comment 3

[(no longer active)]

Comment on attachment 675169 [details] [diff] [review]
Add utility method to get a privacy context from a window.

This is as low-risk as it can get, and it would be really really helpful for add-on developers if we can take this for Firefox 17.

Comment 4

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fea03e42fb87

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 675169 [details] [diff] [review]
Add utility method to get a privacy context from a window.

given the very low risk, i'll pre-approve this even though it's on inbound for now - please go ahead with uplift once it's been merged to central.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fea03e42fb87

Should this have a test?

Comment 7

[(no longer active)]

(In reply to Ryan VanderMeulen from comment #6)
> https://hg.mozilla.org/mozilla-central/rev/fea03e42fb87
> 
> Should this have a test?

isWindowPrivate is tested in a bunch of places, so it does, implicitly.

Comment 8

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a31f0cf46e61
https://hg.mozilla.org/releases/mozilla-beta/rev/8c3b288ab1be