Add utility method to PrivateBrowsingUtils to obtain nsILoadContext from window

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Private Browsing
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

unspecified
Firefox 19
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(firefox17 fixed, firefox18 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Writing up docs for the bug 722872 fiasco, I realized that it sucks to be telling developers how to obtain an nsILoadContext. We should add a GetPrivacyContext method to PrivateBrowsingUtils and get it into FF17.
(Assignee)

Updated

5 years ago
Blocks: 463027
Makes sense.
(Assignee)

Comment 2

5 years ago
Created attachment 675169 [details] [diff] [review]
Add utility method to get a privacy context from a window.
(Assignee)

Updated

5 years ago
Attachment #675169 - Flags: review?(ehsan)
Attachment #675169 - Flags: review?(ehsan) → review+
Comment on attachment 675169 [details] [diff] [review]
Add utility method to get a privacy context from a window.

This is as low-risk as it can get, and it would be really really helpful for add-on developers if we can take this for Firefox 17.
Attachment #675169 - Flags: approval-mozilla-beta?
Attachment #675169 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fea03e42fb87
Comment on attachment 675169 [details] [diff] [review]
Add utility method to get a privacy context from a window.

given the very low risk, i'll pre-approve this even though it's on inbound for now - please go ahead with uplift once it's been merged to central.
Attachment #675169 - Flags: approval-mozilla-beta?
Attachment #675169 - Flags: approval-mozilla-beta+
Attachment #675169 - Flags: approval-mozilla-aurora?
Attachment #675169 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/fea03e42fb87

Should this have a test?
Assignee: nobody → josh
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
(In reply to Ryan VanderMeulen from comment #6)
> https://hg.mozilla.org/mozilla-central/rev/fea03e42fb87
> 
> Should this have a test?

isWindowPrivate is tested in a bunch of places, so it does, implicitly.
https://hg.mozilla.org/releases/mozilla-aurora/rev/a31f0cf46e61
https://hg.mozilla.org/releases/mozilla-beta/rev/8c3b288ab1be
status-firefox17: --- → fixed
status-firefox18: --- → fixed
You need to log in before you can comment on or make changes to this bug.