Created attachment 669502 [details] [diff] [review] v1
Attachment #669502 - Flags: review?(bzbarsky)
Comment on attachment 669502 [details] [diff] [review] v1 This changes the !AllocatedData() case to returning null instead of throwing. Why is that desirable? Alternately, can we nix the whole AllocatedData() thing and require infallible construction for funcstringlists? r=me modulo that.
Attachment #669502 - Flags: review?(bzbarsky) → review+
Target Milestone: --- → mozilla19
https://hg.mozilla.org/mozilla-central/rev/4c979ca3eb7a Should this have a test?
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Maybe, but it's only testable via C++; JS-observed behavior shouldn't have changed here. And I'm not sure how much we care about the C++ behavior of these methods. ;)
6 years ago
Doc updated: https://developer.mozilla.org/en-US/Firefox/Releases/19 https://developer.mozilla.org/en-US/docs/Web/API/Element https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByClassName https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByTagName https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByTagNameNS
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.