Make Element.getElementsBy* return HTMLCollection

RESOLVED FIXED in mozilla19

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

({dev-doc-complete})

Trunk
mozilla19
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 669502 [details] [diff] [review]
v1
Attachment #669502 - Flags: review?(bzbarsky)
Comment on attachment 669502 [details] [diff] [review]
v1

This changes the !AllocatedData() case to returning null instead of throwing.  Why is that desirable?

Alternately, can we nix the whole AllocatedData() thing and require infallible construction for funcstringlists?

r=me modulo that.
Attachment #669502 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c979ca3eb7a
Target Milestone: --- → mozilla19
https://hg.mozilla.org/mozilla-central/rev/4c979ca3eb7a

Should this have a test?
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Maybe, but it's only testable via C++; JS-observed behavior shouldn't have changed here.  And I'm not sure how much we care about the C++ behavior of these methods.  ;)

Updated

5 years ago
Keywords: dev-doc-needed
Doc updated:
https://developer.mozilla.org/en-US/Firefox/Releases/19
https://developer.mozilla.org/en-US/docs/Web/API/Element
https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByClassName
https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByTagName
https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByTagNameNS
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.