Last Comment Bug 799464 - Make Element.getElementsBy* return HTMLCollection
: Make Element.getElementsBy* return HTMLCollection
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla19
Assigned To: Peter Van der Beken [:peterv]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-09 05:59 PDT by Peter Van der Beken [:peterv]
Modified: 2014-09-11 23:23 PDT (History)
5 users (show)
ryanvm: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (20.08 KB, patch)
2012-10-09 05:59 PDT, Peter Van der Beken [:peterv]
bzbarsky: review+
Details | Diff | Splinter Review

Description Peter Van der Beken [:peterv] 2012-10-09 05:59:53 PDT
Created attachment 669502 [details] [diff] [review]
v1
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2012-10-09 12:47:50 PDT
Comment on attachment 669502 [details] [diff] [review]
v1

This changes the !AllocatedData() case to returning null instead of throwing.  Why is that desirable?

Alternately, can we nix the whole AllocatedData() thing and require infallible construction for funcstringlists?

r=me modulo that.
Comment 2 Peter Van der Beken [:peterv] 2012-10-19 07:00:18 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c979ca3eb7a
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-10-19 19:08:59 PDT
https://hg.mozilla.org/mozilla-central/rev/4c979ca3eb7a

Should this have a test?
Comment 4 Boris Zbarsky [:bz] (still a bit busy) 2012-10-19 19:19:37 PDT
Maybe, but it's only testable via C++; JS-observed behavior shouldn't have changed here.  And I'm not sure how much we care about the C++ behavior of these methods.  ;)

Note You need to log in before you can comment on or make changes to this bug.