Closed
Bug 799464
Opened 11 years ago
Closed 11 years ago
Make Element.getElementsBy* return HTMLCollection
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: peterv, Assigned: peterv)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
20.08 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #669502 -
Flags: review?(bzbarsky)
![]() |
||
Comment 1•11 years ago
|
||
Comment on attachment 669502 [details] [diff] [review] v1 This changes the !AllocatedData() case to returning null instead of throwing. Why is that desirable? Alternately, can we nix the whole AllocatedData() thing and require infallible construction for funcstringlists? r=me modulo that.
Attachment #669502 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c979ca3eb7a
Target Milestone: --- → mozilla19
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4c979ca3eb7a Should this have a test?
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
![]() |
||
Comment 4•11 years ago
|
||
Maybe, but it's only testable via C++; JS-observed behavior shouldn't have changed here. And I'm not sure how much we care about the C++ behavior of these methods. ;)
Updated•11 years ago
|
Keywords: dev-doc-needed
Comment 5•9 years ago
|
||
Doc updated: https://developer.mozilla.org/en-US/Firefox/Releases/19 https://developer.mozilla.org/en-US/docs/Web/API/Element https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByClassName https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByTagName https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByTagNameNS
Keywords: dev-doc-needed → dev-doc-complete
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•