799464 - Make Element.getElementsBy* return HTMLCollection

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 669502 [details] [diff] [review]
v1

This changes the !AllocatedData() case to returning null instead of throwing.  Why is that desirable?

Alternately, can we nix the whole AllocatedData() thing and require infallible construction for funcstringlists?

r=me modulo that.

Comment 2

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c979ca3eb7a

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4c979ca3eb7a

Should this have a test?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Maybe, but it's only testable via C++; JS-observed behavior shouldn't have changed here.  And I'm not sure how much we care about the C++ behavior of these methods.  ;)

Comment 5

[Jean-Yves Perrier [:teoli]]

Doc updated:
https://developer.mozilla.org/en-US/Firefox/Releases/19
https://developer.mozilla.org/en-US/docs/Web/API/Element
https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByClassName
https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByTagName
https://developer.mozilla.org/en-US/docs/Web/API/Element.getElementsByTagNameNS