799477 - compilation error in PeerConnectionImpl.cpp: CSFLog.h:68: ‘va_list’ has not been declared

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Nathan Froyd [:froydnj]]

Seen this morning when compiling debug or opt x86-64 Linux build:

In file included from /home/froydnj/src/mozilla-central-official/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:10:
/home/froydnj/src/mozilla-central-official/media/webrtc/signaling//./src/common/browser_logging/CSFLog.h:68: error: ‘va_list’ has not been declared

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

CSFLog.h should include varargs (though it's odd something else hasn't included it before it got there, since every other system seems to have - what OS/Compiler/compiler-revision?)

Comment 2

[Nathan Froyd [:froydnj]]

OS is Debian stable.
Compiler is GCC 4.4.5 (Debian 4.4.5-8).

Comment 3

[Ameya Bapat]

Got the same error.
OS : ubuntu 10.10
Compiler: gcc version 4.4.5 (Ubuntu/Linaro 4.4.4-14ubuntu5.1)

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: missing stdarg.h in CSFLog.h (typically gcc 4.4.x)

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 669615 [details] [diff] [review]
missing stdarg.h in CSFLog.h (typically gcc 4.4.x)

If any of the reporters care to try this patch, that would be useful

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Not that I expect problems... :-)

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fda0797c3abc

Comment 9

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/fda0797c3abc

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 669615 [details] [diff] [review]
missing stdarg.h in CSFLog.h (typically gcc 4.4.x)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): regression from bug 792188
User impact if declined: Can't build with gcc 4.4
Testing completed (on m-c, etc.): Landed on m-c
Risk to taking this patch (and alternatives if risky): Trivial one-line patch adding an standard header include. No risk.
String or UUID changes made by this patch: None

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/49110947421d