799547 - Network stats landing in dom/network broke MozTCPSocket when MOZ_B2G_RIL is defined (like on Otoro devies) by clobbering EXTRA_COMPONENTS in Makefile.in

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Change = to += to not clobber MozTCPSocket

The change of = to += to fix things is rs=jdm

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Landed on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f844ca34b7f

Comment 2

[Marshall Culpepper [:marshall_law]]

Ouch. Nice catch.. do you know if we have any MozTCPSocket tests running in TBPL?

Comment 3

[Josh Matthews [:jdm]]

Not under the RIL configuration, I presume, since I don't think the b2g builds run any tests.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 669602 [details] [diff] [review]
Change = to += to not clobber MozTCPSocket

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 746069
User impact if declined: B2G Gaia e-mail app won't be able to speak IMAP or SMTP on actual phones (b2g-desktop is fine because RIL is not built)
Testing completed (on m-c, etc.): Landed on inbound, not on mozilla-central yet.  Requesting approval early because the fix is a single "+" in a Makefile and it would be nice to get IMAP/SMTP in tonight's b2g nightly now that b2g nightlies have switched to Aurora.
Risk to taking this patch (and alternatives if risky): No risk.  It's a very obvious Makefile fix.
String or UUID changes made by this patch: None.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 669602 [details] [diff] [review]
Change = to += to not clobber MozTCPSocket

Oops, because this is the actual fix for bug 798740 which is a blocker (and this bug just exists for hygiene), I can land this on aurora per https://wiki.mozilla.org/Tree_Rules/B2G, clearing approval request.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

landed on aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/c81cbb2cd989

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f844ca34b7f