799682 - [email] Card implementation needs to be redone to support acceleration (pre-rendering?), vertical animation for settings card

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

Description

[Andrew Sutherland [:asuth] (he/him)]

This is a known issue that we've discussed a few times on github, but punted on because it's a bit more legwork.

We store all our cards in a big div.  The cards are motionless within that div, but we slide that div left-and-right within a clipping div to animate things.

At least as several weeks ago, this resulted in less acceleration because we would only pre-render div's that have a maximum size of 9/8ths of the screen size, and our div is always bigger than that.

A need this creates for us is that we have to listen for resize events and then manually update the sizes of cards, rather than being able to say our cards are 100% of the screen size.  This may be having fallout with the VKB and scrolling entries into focus as in bug 798695.

Comment 1

[James Burke [:jrburke]]

First try at a pull request for this: https://github.com/mozilla-b2g/gaia/pull/6337

Comment 2

[Steve Chung [:steveck]]

Hi James,
Thanks for the great help! Even it is not a blocking-basecamp + issue, it's still an important task for email and not easy to make it perfect.
I've tired to make some small fixing for animation but I could not solved it for 100% correct. It's about the time to fix animation issue once for all. I'll also take a look and verify if it could work perfectly in any cases.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6337#issuecomment-10344142

Pointer to Github pull-request

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 681230 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6337#issuecomment-10344142

This patch is r=asuth on github.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Animations will be slow and ugly
Testing completed: Extensive clicking on stuff on unagi and b2g-desktop.
Risk to taking this patch (and alternatives if risky): The animations are sometimes a little jerky at the end of them, like a re-interpolation is happening for unknown reasons.  I also see this happening in a much worse fashion with the keyboard on both unagi and b2g-desktop, so I suspect there may be a platform issue, but could not find a bug in a bugzilla search.  It is my hope that by landing this we will be able to promptly shake out these issues by making it easy for others to reproduce.  If we have to do this on a branch, I don't see that happening anytime soon.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Andrew Sutherland (:asuth) from comment #4)
> Comment on attachment 681230 [details]
> Pointer to Github pull request:
> https://github.com/mozilla-b2g/gaia/pull/6337#issuecomment-10344142
> 
> This patch is r=asuth on github.
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): 
> User impact if declined: Animations will be slow and ugly
> Testing completed: Extensive clicking on stuff on unagi and b2g-desktop.
> Risk to taking this patch (and alternatives if risky): The animations are
> sometimes a little jerky at the end of them, like a re-interpolation is
> happening for unknown reasons.  I also see this happening in a much worse
> fashion with the keyboard on both unagi and b2g-desktop, so I suspect there
> may be a platform issue, but could not find a bug in a bugzilla search.  It
> is my hope that by landing this we will be able to promptly shake out these
> issues by making it easy for others to reproduce.  If we have to do this on
> a branch, I don't see that happening anytime soon.

Can you fix the interpolation issue by adding overflow: hidden on all sides? I wonder if it is related to scrollbars coming in the way.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Vivien Nicolas (:vingtetun) from comment #5)
> Can you fix the interpolation issue by adding overflow: hidden on all sides?
> I wonder if it is related to scrollbars coming in the way.

It appears to have been a platform issue that was recently fixed.  The 11-26 build shows no problems, whereas 11-22 and 11-20 builds showed jerkiness.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 681230 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6337#issuecomment-10344142

(clearing approval because we got blocking+)

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/6337

Thanks again, James!

Comment 9

[amiller]

Device: Unagi
Build: 20130114073222
Does not repro on this device or build at this time.