799725 - [css-flexbox] "align-self:stretch" doesn't work on table flex items

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

STR: Load testcase, in a profile with layout.css.flexbox.enabled = true

EXPECTED RESULTS: Lime "abc" regions stretch from top-to-bottom in the first gray block, and from left-to-right in the second gray block.

ACTUAL RESULTS: Lime "abc" regions shrinkwrap their text.


Firefox nightly and google-chrome dev channel (ver 24.0.1284.2 dev) show ACTUAL RESULTS.

opera-next (12.10 beta RC) shows EXPECTED RESULTS.

Comment 2

[Daniel Holbert [:dholbert]]

Chrome dev channel (Version 55.0.2873.0 dev (64-bit) and Edge 14 match our behavior here...

So this behavior seems to be interoperable at this point, though I'm not sure why.

Comment 3

[Daniel Holbert [:dholbert]]

(Per comment 0, I guess Chrome matched our behavior back when I filed this, too.)

Comment 4

[yisibl]

Attachment: Opera 12 test.png

Comment 5

[yisibl]

Attachment: Testcase2.html

Improve test cases.

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I have idea on fixing this after fixing bug 1674302.

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 799725 Part 2 - Use StyleSizeOverrides to stretch flex item's inline-size.

We also need to ignore aspect-ratio when measuring the content
block-size, because we don't want the stretched inline-size transferring
through aspect-ratio to set block-size. Otherwise,
testing/web-platform/tests/css/css-flexbox/flex-minimum-height-flex-items-023.html
is going to break.

table-as-item-stretch-cross-size-3 is adapted from the testcase in bug
799725 comment 1. Note: stretching in the cross axis that is a block
axis has been fixed by bug 1674302.

Comment 8

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 799725 Part 1 - Support AspectRatio in StyleSizeOverrides.

This is a preparation patch for Part 2 -- We need a way to ignore
aspect-ratio when measuring a flex item's content block-size, because we
don't want the stretched inline-size transferring through aspect-ratio
to set block-size.

This patch hasn't changed the behavior yet. Part 2 is going to utilize
mAspectRatio.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cad4644254f
Part 1 - Support AspectRatio in StyleSizeOverrides. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/0036bd0a6056
Part 2 - Use StyleSizeOverrides to stretch flex item's inline-size. r=dholbert

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27783 for changes under testing/web-platform/tests

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8cad4644254f
https://hg.mozilla.org/mozilla-central/rev/0036bd0a6056

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot