Closed Bug 799812 Opened 13 years ago Closed 13 years ago

Android NoIon builds need to bump their branding on merge day

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(firefox18 fixed)

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(1 file)

So, I noticed that after we turned on Android NoIon builds on aurora, we were failing to properly run any and all of our tests. It dawned on me to check the branding bump we did (https://hg.mozilla.org/releases/mozilla-aurora/rev/c56fd6ea49c4 ) And it seems we did not add NoIon to that checkin. (https://hg.mozilla.org/releases/mozilla-aurora/file/c81cbb2cd989/mobile/android/config/mozconfigs/android-noion/nightly#l24) This attached patch should hopefully fix it, and will be needed on this and future uplifts to keep Android NoIon tests sane until we drop Android NoIon. --approval requested even prior to r+, since this should unbork noion tests on aurora.
Attachment #669843 - Flags: review?(armenzg)
Attachment #669843 - Flags: approval-mozilla-aurora?
Comment on attachment 669843 [details] [diff] [review] [m-aurora] update noion for aurora Oh dear...
Attachment #669843 - Flags: review?(armenzg) → review+
Blocking on next uplift bug.
Blocks: 786550
Comment on attachment 669843 [details] [diff] [review] [m-aurora] update noion for aurora Approving the patch as this is restricted to NoIon builds which are not user facing ..
Attachment #669843 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee: nobody → bugspam.Callek
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: