cairo-qt fails to build

RESOLVED FIXED in Firefox 18

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jan Beich, Assigned: Jan Beich)

Tracking

({regression})

Trunk
mozilla19
x86_64
FreeBSD
regression
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox18 fixed, firefox19 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
regressed after this commit
https://hg.mozilla.org/mozilla-central/rev/062549aab268

mozilla-central-dd61540f237c/gfx/layers/opengl/CanvasLayerOGL.cpp: In member function 'virtual void mozilla::layers::CanvasLayerOGL::Initialize(const mozilla::layers::CanvasLayer::Data&)':
mozilla-central-dd61540f237c/gfx/layers/opengl/CanvasLayerOGL.cpp:135: error: 'class gfxXlibSurface' has no member named 'GetGLXPixmap'
(Assignee)

Comment 1

5 years ago
Got the order wrong.
https://hg.mozilla.org/mozilla-central/rev/4e1c9887f87d
Depends on: 788042
(Assignee)

Comment 2

5 years ago
Created attachment 669855 [details] [diff] [review]
Bug 799813 - Apply bug 788042 under gfx/thebes to fix cairo-qt build on Linux.

More easy to read with clang:

  gfx/layers/opengl/CanvasLayerOGL.cpp:135:26: error:
	no member named 'GetGLXPixmap' in 'gfxXlibSurface'
	  mPixmap = xsurf->GetGLXPixmap();
		    ~~~~~  ^
  1 error generated.
Attachment #669855 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #669855 - Flags: review? → review?(karlt)
Comment on attachment 669855 [details] [diff] [review]
Bug 799813 - Apply bug 788042 under gfx/thebes to fix cairo-qt build on Linux.

These files are only built when MOZ_X11 is set, so no need to include defined(MOZ_X11).

(I guess these tests perhaps should all be based on MOZ_GL_PROVIDER, but currently that's hard to use and I imagine we'll eventually want to generalize the interface to GetGLSurface or similar, so just the !defined(MOZ_PLATFORM_MAEMO) is good for now.  I don't even know if anyone still builds for Maemo.)
Attachment #669855 - Flags: review?(karlt) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 669943 [details] [diff] [review]
Bug 799813 - Qt/Linux needs GetGLXPixmap() after bug 788042. r=karlt
Attachment #669855 - Attachment is obsolete: true
Attachment #669943 - Flags: review?(karlt)
Attachment #669943 - Flags: review?(karlt) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/6307602406c1
Assignee: nobody → jbeich
Flags: in-testsuite-
Keywords: checkin-needed

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/6307602406c1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(Assignee)

Comment 7

5 years ago
Comment on attachment 669943 [details] [diff] [review]
Bug 799813 - Qt/Linux needs GetGLXPixmap() after bug 788042. r=karlt

[Approval Request Comment]
User impact if declined: broken cairo-qt on Linux (non-Maemo) or other X11 platforms
Risk to taking this patch: broken build for cairo-gtk2 on Linux
Attachment #669943 - Flags: approval-mozilla-aurora?
Keywords: regression
Attachment #669943 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/releases/mozilla-aurora/rev/8f3c3170cc8c
status-firefox18: --- → fixed
status-firefox19: --- → fixed
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.