Closed Bug 799834 Opened 7 years ago Closed 7 years ago

Connect Android campaign product announcements preference to background service

Categories

(Firefox for Android :: General, defect, P1)

ARM
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 19
Tracking Status
firefox18 --- fixed

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

(Whiteboard: [snippets])

Attachments

(1 file)

Splitting this out to avoid bug confusion.
Depends on: 798043
It turns out that preferences.xml stores its stuff somewhere other than GeckoApp's SharedPreferences file. This version is much simpler, because we just grab the value and send it out, rather than doing a dance with the receiver.
Attachment #670243 - Flags: review?(snorp)
Blocks: 793053
Attachment #670243 - Flags: review?(snorp) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e8d0365d630

Thanks, James!
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 19
https://hg.mozilla.org/mozilla-central/rev/6e8d0365d630
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment on attachment 670243 [details] [diff] [review]
Proposed patch. v1

Requesting Aurora approval to get product announcements (Bug 774497) into Firefox 18.

Impact: essentially zero. This just makes some log noise when you check and uncheck the "Show product announcements" checkbox in Fennec's settings screen.

No strings.
Attachment #670243 - Flags: approval-mozilla-aurora?
Attachment #670243 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #670243 - Flags: approval-mozilla-aurora+ → approval-mozilla-aurora?
(before approving this and all other product announcement bugs, need to talk to the product team to verify they've discussed with the l10n community, if there is l10n impact)
(In reply to Alex Keybl [:akeybl] from comment #5)
> (before approving this and all other product announcement bugs, need to talk
> to the product team to verify they've discussed with the l10n community, if
> there is l10n impact)

If you mean for the Fennec side, the only string already landed in 18. 

The server side is unrelated. Presumably product marketing and Services engineering are formulating a plan for how to generate the family of localized content that should be available to targeted locales, but the client doesn't care.
Comment on attachment 670243 [details] [diff] [review]
Proposed patch. v1

Approving as this patch does not have an l10n impact as the string changes are server side.
Attachment #670243 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.