Closed Bug 799908 Opened 13 years ago Closed 13 years ago

TBPL should adjust the baseURL automatically if testing the client-side from the local filesystem

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently we can test client-side only changes by running index.html from the local filesystem & pointing the UI at the production server-side components. However this requires changing baseURL in Config.js every time I want to test locally. I do this by popping/pushing an mq, but it's still a PITA to have to remember to do - and if I forget to push the mq before starting the next patch, I inevitably end up at some point qrefreshing parts of the patch into my baseURL mq patch. We should just detect "file:" in window.location.protocol and set the value automatically to save this messing about.
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #669939 - Flags: review?(arpad.borsos)
Meant to add: The reason for keeping baseURLOverride around (even though we now deal with the local filesystem case automatically), is in case people wish to point to tbpl-dev.allizom.org or say host just the UI from their own domain & still use tbpl.mozilla.org for the backend.
Attached patch Patch v2Splinter Review
I think this is simpler.
Attachment #669977 - Flags: review?(arpad.borsos)
Attachment #669939 - Attachment is obsolete: true
Attachment #669939 - Flags: review?(arpad.borsos)
Attachment #669977 - Flags: review?(arpad.borsos) → review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Depends on: 799720
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: