Closed Bug 799913 Opened 8 years ago Closed 7 years ago

Remove support for the Zapf Dingbats encoding and other dead-code encoder-only encodings

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: hsivonen, Assigned: hsivonen)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

We have support for x-zapf-dingbats but it does not appear to be exposed to the Web or used in font code:
http://mxr.mozilla.org/mozilla-central/ident?i=zapf&tree=mozilla-central&filter=

It was added by Frank Tang in 1999 with the helpful comment “add unicode encoders”.

Let’s remove it.
Assignee: nobody → hsivonen
Summary: Remove support for the Zapf Dingbats encoding → Remove support for the Zapf Dingbats encoding and other dead-code encoder-only encodings
Attached patch Remove dead code (obsolete) — Splinter Review
Awesome. We've had bogus comments in a property file for a long time, but the entry after the comments was useless, so no one noticed.

https://tbpl.mozilla.org/?tree=Try&rev=484564b87ce1
Attachment #8355179 - Attachment is obsolete: true
Comment on attachment 8355210 [details] [diff] [review]
Remove dead code, fix property file comments

It seems to me that these encodings exist, because year ago the X11 gfx code knew about font-specific encodings and this stuff wasn't fully removed when X11 gfx moved to FreeType2, etc.
Attachment #8355210 - Flags: review?(VYV03354)
Attachment #8355210 - Flags: review?(VYV03354) → review+
https://hg.mozilla.org/mozilla-central/rev/89b66dd9847a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.