Closed Bug 799977 Opened 12 years ago Closed 12 years ago

java.lang.NullPointerException: at org.mozilla.gecko.Tabs.loadUrlInTab(Tabs.java)

Categories

(Firefox for Android Graveyard :: General, defect, P1)

19 Branch
ARM
Android
defect

Tracking

(firefox19+ fixed, fennec19+)

RESOLVED FIXED
Firefox 19
Tracking Status
firefox19 + fixed
fennec 19+ ---

People

(Reporter: scoobidiver, Assigned: bnicholson)

References

Details

(Keywords: crash, regression, topcrash, Whiteboard: [native-crash][startupcrash])

Crash Data

Attachments

(1 file)

It first appeared in 19.0a1/20121010 and has been hit by 3 users. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=aa5e3b445810&tochange=ec10630b1a54
It's likely a regression from bug 797075.

java.lang.NullPointerException
	at org.mozilla.gecko.Tabs.loadUrlInTab(Tabs.java:505)
	at org.mozilla.gecko.AboutHomeContent$11$1.onClick(AboutHomeContent.java:557)
	at android.view.View.performClick(View.java:4084)
	at android.view.View$PerformClick.run(View.java:16966)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4931)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:791)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:558)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.Tabs.loadUrlInTab%28Tabs.java%29
Assignee: nobody → bnicholson
Depends on: 800199
tracking-fennec: --- → ?
Keywords: topcrash
tracking-fennec: ? → 19+
This regression is our #1 topcrash in Nightly 19.
Priority: -- → P1
This should be fixed by bug 800199.
(In reply to Brian Nicholson (:bnicholson) from comment #2)
> This should be fixed by bug 800199.

why not back out bug 797075 in the meantime?
(In reply to Alex Keybl [:akeybl] from comment #3)
> (In reply to Brian Nicholson (:bnicholson) from comment #2)
> > This should be fixed by bug 800199.
> 
> why not back out bug 797075 in the meantime?

The fix in bug 797075 was ready...it was just waiting for review. It's landed now, so hopefully this bug is fixed.
(In reply to Brian Nicholson (:bnicholson) from comment #4)
> The fix in bug 797075 was ready...it was just waiting for review. It's
> landed now, so hopefully this bug is fixed.

That is, bug 800199.
There are still crashes after the fix of bug 800199, at a lower volume though.
This crash happens whenever loadUrlInTab() is called when there are no existing tabs. Bug 800199 fixed the majority of cases since the most common cause was clicking a "tab from last time" [1]. But this can still happen if both a) we're doing a session restore (which means no about:home stub at startup) AND b) the user clicks addons, downloads, or apps in the menu before Gecko has loaded [2].

I saw this before and have a fix in patch 6 of bug 722661 (see the very bottom of [3]). Since the combined conditions required to trigger this seemed pretty rare, I didn't think this would happen much. Since they are, though, I'll just take the part of that patch for this bug so we don't need to wait for bug 722661's review.

[1] http://hg.mozilla.org/integration/mozilla-inbound/file/62627192e156/mobile/android/base/AboutHomeContent.java.in#l535
[2] http://hg.mozilla.org/integration/mozilla-inbound/file/62627192e156/mobile/android/base/BrowserApp.java#l956
[3] https://bug722661.bugzilla.mozilla.org/attachment.cgi?id=672171
Attachment #672982 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/04b94f89672f
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.