Closed Bug 800044 Opened 7 years ago Closed 7 years ago

Hide private browsing menu item

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 19
Tracking Status
firefox19 --- verified

People

(Reporter: bnicholson, Assigned: bnicholson)

Details

Attachments

(1 file, 1 obsolete file)

Bug 582244 was landed, but there's still lots of open dependencies for private browsing before it can be considered usable (bug 794502). This patch disables the menu item by default and adds a "browser.ui.privatebrowsing.enabled" pref.
Attachment #670041 - Flags: review?(mark.finkle)
Comment on attachment 670041 [details] [diff] [review]
Disable private browsing menu item by default

Review of attachment 670041 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, Brian!
Comment on attachment 670041 [details] [diff] [review]
Disable private browsing menu item by default

Let's just simplify this patch to always hide the menu. We have enough work to do, so just hide the menu in the XML.

I suggested this approach, but now I think it's overkill.
Attachment #670041 - Flags: review?(mark.finkle) → review-
Attachment #670041 - Attachment is obsolete: true
Attachment #670564 - Flags: review?(mark.finkle)
Attachment #670564 - Flags: review?(mark.finkle) → review+
Summary: Disable private browsing menu item by default → Hide private browsing menu item
https://hg.mozilla.org/mozilla-central/rev/31bfd182d836
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.