800086 - App status should be updated from "rejected.." to "pending approval" when a new version is updated

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Upload a packaged app. Apps status is "pending approval"
2. As a reviewer, reject the app.
3. Upload a new version which is now "pending approval"
4. Notice the app status.

expected behavior:
When the app developers uploads a new version to a previously rejected app, the status changes to "pending approval"

observed behavior:
a) The app status remains "rejected" and there is no way for the developer to seek review.
b) The newly uploaded version is not listed in the review queues.

Comment 1

[Rob Hudson [:robhudson]]

There are some other scenarios that we have to handle, so I'm putting them here to think through...

1. Original bug: New app submitted, reviewer rejects so app status is rejected and version is disabled. On new version is upload, app status doesn't change from rejected status.

2. New app submitted, reviewer rejects so app status is rejected and version is disabled, developer deletes version and app status becomes incomplete. On new version upload, app status doesn't change from incomplete status.

The others I'm trying to think are further extensions. For example:

3. App status = rejected
   Version 1.1 = disabled
   Version 1.0 = disabled
Developer deletes version 1.1 and we see that the status is rejected and there are no public versions -- should we change the status to incomplete? Leave it as-is? Since the developer can't change a version from "Disabled by Mozilla", my vote would be to consider it incomplete. But is it bad that it was rejected and we changed it to incomplete on a version deletion? Should we only set incomplete if there are no versions?

Comment 2

[Rob Hudson [:robhudson]]

The logic I'm honing in on is this:

If app is disabled or deleted: do nothing.
If app has no versions or files: set status to incomplete.
If app has no public versions and any pending version: set status to pending.

I think that covers all the cases above...

1. On new version upload, app would now have 1 pending version, so app status is set to pending.
2. When dev deletes all versions, app status becomes incomplete. And when dev adds a new pending version, app status is set to pending.
3. When dev deletes either disabled version, app status remains rejected because there are no public versions and also no pending versions.

Comment 3

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/f20cb91

Comment 4

[Rob Hudson [:robhudson]]

Follow up commit to handle blocklisting:
https://github.com/mozilla/zamboni/commit/1b53310

Comment 5

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/developers/ on FF19 (Win 7)
Postfix screencast http://screencast.com/t/vcGOh01xhZp
Closing bug.