800204 - Remove Gaia window manager getScreenshot workaround for bug 787519

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Justin Lebar (not reading bugmail)]

There's a workaround for bug 787519 in the Gaia window manager.  That bug is now resolved.  Can we remove the workaround?

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The "workaround" currently involves a timeout to ensure the window transition starts even if |onsuccess| nor |onerror| files. The time is set to 700ms.

However, on Otoro, I found that sometimes getScreenshot() takes more than 700ms to return, which is confusing for the user and can be considered ill-responsive to them. So I propose we keep the timeout, not as a workaround but maximum threshold that we will be waiting for getScreenshot() to start the transition.

We'll still need to update the comment in the code to "fix" this bug :-P

Comment 2

[Justin Lebar (not reading bugmail)]

700ms to get a screenshot?!  That's a bug.

Anyway, let me fix bug 800170, which may greatly improve the speed of screenshotting.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Once bug 801306 landed, timeout is safe to be removed since we no longer taking screenshots during a user action. I would like to remove app-to-app transition screenshot taking before fixing this bug.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/6347

https://github.com/mozilla-b2g/gaia/pull/6347

This patch trims window manager more by removing dead code. screenshot-taking is no-longer a part of app transitioning flow (but screenshot-getting from database is); get this into window manager will keep our shipping code cleaner with fewer possible errors.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): workaround of bug 787519
User impact if declined: none
Testing completed: yes
Risk to taking this patch (and alternatives if risky): pure clean up, user will not likely to hit the code path changed.

Comment 5

[Andreas Gal :gal]

r/a=gal