800247 - [b2g-bluetooth] User has no way of knowing when device disconnects.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Repro:

1. Connect to paired, powered on device
2. Power off device

Expected:

Disconnection is relayed to gaia

Actual:

Gaia says still connected

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Add disconnect events to UnixSocket, update Bluetooth*Manager

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 670252 [details] [diff] [review]
Patch 1 (v1) - Add disconnect events to UnixSocket, update Bluetooth*Manager

cjones for unixsocket stuff, echou for manager stuff (not that there's much of it really)

Comment 3

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 670252 [details] [diff] [review]
Patch 1 (v1) - Add disconnect events to UnixSocket, update Bluetooth*Manager

Review of attachment 670252 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 4

[Andrew Overholt [:overholt]]

Important UI consideration

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 670252 [details] [diff] [review]
Patch 1 (v1) - Add disconnect events to UnixSocket, update Bluetooth*Manager

>diff --git a/ipc/unixsocket/UnixSocket.cpp b/ipc/unixsocket/UnixSocket.cpp

>@@ -608,7 +632,8 @@ UnixSocketImpl::OnFileCanReadWithoutBlocking(int aFd)
>         mIncoming.forget();
>         mReadWatcher.StopWatchingFileDescriptor();
>         mWriteWatcher.StopWatchingFileDescriptor();
>-        mConsumer->CloseSocket();
>+        nsRefPtr<SocketCloseTask> t = new SocketCloseTask(this);
>+        NS_DispatchToMainThread(t);

It doesn't matter here, but a good habit to be in is to use

 NS_DispatchToMainThread(new SocketCloseTask(this));

to ensure that the destructor for your task runs on the main thread,
not accidentally on the dispatching thread.  (Note that you're holding
a strong ref here in the dispatcher.)

I can't tell you how much gnashing of teeth and rending of garments
I've seen from those kinds of bugs!  And I bet bent could tell you
even more great stories about those over beer sometime.

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d5627f5882b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d5627f5882b

Should this have a test?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/916e162d0240