800261 - B2G STKUI: Support STK_CMD_PLAY_TONE

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

As implemented Bug 793137, we need to support "Play Tone".

This is needed for remote SIM activation.

Comment 1

[Alex Keybl [:akeybl]]

blocking-basecamp+ based upon the blocking status of bug 793137. CC dietrich and clee so that they're aware of the lingering feature.

Comment 2

[Patryk Adamczyk [:patryk] UX]

From a design angle... Do we need anything for this? Assets?

Comment 3

[Marcelino Veiga Tuimil [:sonmarce]]

(In reply to Patryk Adamczyk [:patryk] UX from comment #2)
> From a design angle... Do we need anything for this? Assets?

We are using building blocks but some minor tweaks for the whole SKT implementation. @rafaelrebolleda was working on it.

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Patch to support PLAY TONE commands

This version only includes ONE tone (default one). Who can provide more tones? UX?

Comment 5

[Patryk Adamczyk [:patryk] UX]

(In reply to Fernando R. Sela from comment #4)
> Created attachment 671456 [details] [diff] [review]
> Patch to support PLAY TONE commands
> 
> This version only includes ONE tone (default one). Who can provide more
> tones? UX?

Can you send me a requirements spec? What exactly is needed, how many tones, what are they used for?

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Patryk Adamczyk [:patryk] UX from comment #5)
> Can you send me a requirements spec? What exactly is needed, how many tones,
> what are they used for?

Hi, Patryk

The spec is from 3GPP TS 11.14, clause 12.16 Tone

I list the values below.
'01' Dial tone
'02' Called subscriber busy
'03' Congestion
'04' Radio path acknowledge
'05' Radio path not available / Call dropped
'06' Error / Special information
'07' Call waiting tone
'08' Ringing tone
'10' General beep
'11' Positive acknowledgement tone
'12' Negative acknowledgement or error tone


Also Android has a class called ToneGenerator will generate these tones.

http://developer.android.com/reference/android/media/ToneGenerator.html

Comment 7

[Andreas Gal :gal]

Can we inherit these tones from Android instead of using Patryk for this? This seems low priority.

Comment 8

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

The Android ToneGenerator is for generate DTMF tones ... we can use the MozTelephony tone methods:

https://developer.mozilla.org/en-US/docs/DOM/Telephony.startTone
https://developer.mozilla.org/en-US/docs/DOM/Telephony.stopTone

So next step is: which tone to use for each of the 3GPP tones? ... :)

Comment 9

[Patryk Adamczyk [:patryk] UX]

Yes, I'd mirror Andreas' response and mirror the tones from Android if we can.

Comment 10

[Andrew Overholt [:overholt]]

Fernando, how are things going here?

Comment 11

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Andrew Overholt [:overholt] from comment #10)
> Fernando, how are things going here?

Hi,

As I told on comment #8, I can use tones generated by the mozTelephony API or ogg files (as the current patch is using)

So the patch is only waiting for the final tones :p

In the http://developer.android.com/reference/android/media/ToneGenerator.html we've the frequencies and times per each tone so it's easy to generate it but my question is: Which tone we should use for each of the STK tone required? :

'01' Dial tone
'02' Called subscriber busy
'03' Congestion
'04' Radio path acknowledge
'05' Radio path not available / Call dropped
'06' Error / Special information
'07' Call waiting tone
'08' Ringing tone
'10' General beep
'11' Positive acknowledgement tone
'12' Negative acknowledgement or error tone

Comment 12

[Patryk Adamczyk [:patryk] UX]

Attachment: DTMF Tones

Comment 13

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Patryk Adamczyk [:patryk] UX from comment #12)
> Created attachment 677739 [details]
> DTMF Tones

Cool, Thank you Patryk.

These tones are the DTMF ones, but we also need others to represent this events:

 * Dial tone
 * Called subscriber busy
 * Congestion
 * Radio path acknowledge
 * Radio path not available / Call dropped
 * Error / Special information
 * Call waiting tone
 * Ringing tone
 * General beep
 * Positive acknowledgement tone
 * Negative acknowledgement or error tone

Is it possible to also cover these events? Thanks in advance. Feel free to use the tones you prefer.

In order to help: Here are the Android ones: (http://developer.android.com/reference/android/media/ToneGenerator.html)

For example:

TONE_SUP_DIAL 	Call supervisory tone, Dial tone: CEPT: 425Hz, continuous ANSI (IS-95): 350Hz+440Hz, continuous JAPAN: 400Hz, continuous

Comment 14

[Andreas Gal :gal]

Patryk, whats the ETA for these?

Comment 15

[Patryk Adamczyk [:patryk] UX]

Attachment: DTMF Tones

Comment 16

[Patryk Adamczyk [:patryk] UX]

Attachment: Signal Tones

Comment 17

[Patryk Adamczyk [:patryk] UX]

I attached the final DTMF tones and the signal tones (still need to get those optimized for OGG format), let me know if it all works we you expected.

Comment 18

[Fabien Cazenave [:kaze]]

Comment on attachment 671456 [details] [diff] [review]
Patch to support PLAY TONE commands

>+    if (options.text) {
>+      alert(options.text);
>+    }

Please drop the alert() call.

Comment 19

[Patryk Adamczyk [:patryk] UX]

Attachment: Optimized Signal Tones

Comment 20

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Patch to support PLAY TONE commands (with new tones)

Comment 21

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Patch to support PLAY TONE commands (with new tones and without alert() call)

Comment 22

[Alex Keybl [:akeybl]]

Milestoning for C2 (deadline of 12/10), as this meets the criteria of "remaining P1 bugs not already milestoned for C1".

Comment 23

[Fabien Cazenave [:kaze]]

It would be much easier to test and review with a pull request…

>+     case icc.STK_TONE_TYPE_NEGATIVE_ACK_TONE:
>+       selectedPhoneSound = 'tones/300Hz+400Hz+500Hz_400ms_16bit_48kHz_-1dBFS_mono.ogg';
>+       break;

* using shorter file names would be nice;
* please use a `resources/dtmf_tones' directory for that (see `resources/ringtones')

Comment 24

[Fabien Cazenave [:kaze]]

Fernando, please link to a github pull request so I can r+ it. Thanks!

Comment 25

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: PR link to support PLAY TONE commands

Moved tone files to resources folder

Comment 26

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Fabien Cazenave [:kaze] from comment #23)
> It would be much easier to test and review with a pull request…
> 
> >+     case icc.STK_TONE_TYPE_NEGATIVE_ACK_TONE:
> >+       selectedPhoneSound = 'tones/300Hz+400Hz+500Hz_400ms_16bit_48kHz_-1dBFS_mono.ogg';
> >+       break;
> 
> * using shorter file names would be nice;
> * please use a `resources/dtmf_tones' directory for that (see
> `resources/ringtones')

I just reduced the tones filenames in the GitHub PR

Comment 27

[Fabien Cazenave [:kaze]]

Comment on attachment 681428 [details]
PR link to support PLAY TONE commands

Nice work! Merging.

Comment 28

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Great! Thanks Kaze.