800268 - B2G STKUI: Add support to STK_CMD_DTMF

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Support DTMF tones on STK application

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Patch to support DTMF commands

Yoshi told me:

see http://www.kandroid.org/online-pdk/guide/stk.html

For SEND_SMS, SEND_SS, SEND_USSD, SET UP CALL and SEND_DTMF
the modem will handle this,
so we just need to display the text message to user.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 671749 [details] [diff] [review]
Patch to support DTMF commands

Review of attachment 671749 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, modem will handle this,
also you could check the Stk app on Android for reference.

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 671749 [details] [diff] [review]
Patch to support DTMF commands

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Fernando R. Sela from comment #3)
> Comment on attachment 671749 [details] [diff] [review]
> Patch to support DTMF commands
> 
> NOTE: If blocking-basecamp+ is set, just land it for now.
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): 
> User impact if declined: 
> Testing completed: 
> Risk to taking this patch (and alternatives if risky):

Please ignore this comment is a copy-paste mistake !

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 671749 [details] [diff] [review]
Patch to support DTMF commands

Review of attachment 671749 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/settings/js/icc.js
@@ +147,4 @@
>        case icc.STK_CMD_SEND_SMS:
>        case icc.STK_CMD_SEND_SS:
>        case icc.STK_CMD_SEND_USSD:
> +      case STK_CMD_SEND_DTMF:

Is it not supposed to be icc.STK_CMD_SEND_DTMF ?

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Vivien Nicolas (:vingtetun) from comment #5)
> Comment on attachment 671749 [details] [diff] [review]
> Patch to support DTMF commands
> 
> Review of attachment 671749 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: apps/settings/js/icc.js
> @@ +147,4 @@
> >        case icc.STK_CMD_SEND_SMS:
> >        case icc.STK_CMD_SEND_SS:
> >        case icc.STK_CMD_SEND_USSD:
> > +      case STK_CMD_SEND_DTMF:
> 
> Is it not supposed to be icc.STK_CMD_SEND_DTMF ?

Yes, that's true ... I'll fix asap. thanks

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Patch to support DTMF commands V1.1

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 671772 [details] [diff] [review]
Patch to support DTMF commands V1.1

Review of attachment 671772 [details] [diff] [review]:
-----------------------------------------------------------------

I also think you want to ask r? instead of f? :)

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Merged: https://github.com/mozilla-b2g/gaia/commit/a27ceb0fd2e2d2f8b621e28c2f9ccb15c36e82bf

Comment 10

[Natalya Kot [:nkot]]

Unagi Build ID:20130113070202 - DTMF functions in dialer