800288 - 'Download fennec_ids.txt' build step should RETRY on "ERROR 500: Internal Server Error"

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

We got a result:2, not a RETRY, from:
https://tbpl.mozilla.org/php/getParsedLog.php?id=16003277&tree=Mozilla-Inbound

{
========= Started Download fennec_ids.txt failed (results: 2, elapsed: 31 secs) (at 2012-10-10 21:06:24.539840) =========
wget --progress=dot:mega --no-verbose -N http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android/1349922974/fennec_ids.txt
 in dir /builds/tegra-232/test/../talos-data (timeout 1200 secs)
 watching logfiles {}
 argv: ['wget', '--progress=dot:mega', '--no-verbose', '-N', u'http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android/1349922974/fennec_ids.txt']
 environment:
  HOME=/Users/cltbld
  PATH=/opt/local/bin:/opt/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin
  PWD=/builds/tegra-232/talos-data
  SUT_IP=10.250.51.72
  SUT_NAME=tegra-232
  __CF_USER_TEXT_ENCODING=0x1F5:0:0
 closing stdin
 using PTY: False
http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android/1349922974/fennec_ids.txt:
2012-10-10 21:06:56 ERROR 500: Internal Server Error.
program finished with exit code 8
elapsedTime=31.854933
========= Finished Download fennec_ids.txt failed (results: 2, elapsed: 31 secs) (at 2012-10-10 21:06:56.419291) =========
}

Comment 1

[Justin Wood (:Callek)]

Attachment: [custom] v1

This is attempt 1 at this patch, and is entirely untested so far.

Mostly looking for if this approach looks right to you, before I test it anywhere, the way DownloadFile is implemented I can't just wrap it in addRetryEvaluateCommand afaict.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 681403 [details] [diff] [review]
[custom] v1

Review of attachment 681403 [details] [diff] [review]:
-----------------------------------------------------------------

Is there a reason you can't inherit from RetryingShellCommand?

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 681403 [details] [diff] [review]
[custom] v1

Review of attachment 681403 [details] [diff] [review]:
-----------------------------------------------------------------

The retry stuff needs to be factored out somewhere - whether DownloadFile inherits from RetryingShellCommand or there's some other shared code I don't care.

Comment 4

[Justin Wood (:Callek)]

I think Bug 811279 will end up solving this... Marking a dependancy just in case it doesn't (we'll check, if it does we'll dupe)

Comment 5

[Ed Morley [:emorley]]

Fixed by bug 811279.