multiple locales don't build properly on win32, empty values break

RESOLVED FIXED in Firefox 17

Status

()

Toolkit
NSIS Installer
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: Pike)

Tracking

17 Branch
mozilla19
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox17+ fixed, firefox18+ fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We got the following error when trying to build it:
Traceback (most recent call last):
  File "e:/builds/moz2_slave/rel-m-beta-w32-rpk-4/mozilla-beta/toolkit/mozapps/installer/windows/nsis/preprocess-locale.py", line 321, in <module>
    preprocess_locale_files(config_dir, l10n_dirs)
  File "e:/builds/moz2_slave/rel-m-beta-w32-rpk-4/mozilla-beta/toolkit/mozapps/installer/windows/nsis/preprocess-locale.py", line 110, in preprocess_locale_files
    True)
  File "e:/builds/moz2_slave/rel-m-beta-w32-rpk-4/mozilla-beta/toolkit/mozapps/installer/windows/nsis/preprocess-locale.py", line 48, in get_locale_strings
    if value[-1] == "\"" and value[0] == "\"":
IndexError: string index out of range
make[2]: *** [l10ngen/setup.exe] Error 1
make[1]: *** [repackage-win32-installer] Error 2
make: *** [repackage-win32-installer-km] Error 2
(Assignee)

Comment 1

5 years ago
ok, this happens when a value is empty. This will affect more than just one locale, I assume (at least hy-AM is on my list of candidates, too).

I suggest we patch this in preprocess-locale.py, and make that bullet-proof.
Component: Localization → NSIS Installer
Product: Core → Toolkit
Version: unspecified → 17 Branch
(Assignee)

Comment 2

5 years ago
Created attachment 670370 [details] [diff] [review]
check for value before checking its contents

This patch applies to mozilla-beta, we should back-port it to aurora and central.

Taking ted as reviewer, as he's reviewing code there before.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
Attachment #670370 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 3

5 years ago
PS: This has been the case since the initial port of preprocess-locale from perl to python, but only recently got triggered by some locales having empty strings in the installer .properties files.

Notably, that's in narro exports, AFAICT.

Either way, we should make the python script bullet proof, IMHO.
Summary: km didn't build properly for Firefox 17.0b1 win32 → multiple locales donn't build properly on win32, empty values break
Attachment #670370 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed

Updated

5 years ago
tracking-firefox17: --- → +
tracking-firefox18: --- → +
https://hg.mozilla.org/integration/mozilla-inbound/rev/057589f16a3a
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/057589f16a3a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment on attachment 670370 [details] [diff] [review]
check for value before checking its contents

[Triage Comment]
We need this on Beta and Aurora too - Axel's away can someone check this in today please so it's in tomorrow's Beta build?
Attachment #670370 - Flags: approval-mozilla-beta+
Attachment #670370 - Flags: approval-mozilla-aurora+
Keywords: checkin-needed
status-firefox17: --- → affected
status-firefox18: --- → affected
https://hg.mozilla.org/releases/mozilla-beta/rev/c9f397f91cce
status-firefox17: affected → fixed
Keywords: checkin-needed
(Still c-n for aurora)
Keywords: checkin-needed
https://hg.mozilla.org/releases/mozilla-aurora/rev/1796bbed0299
status-firefox18: affected → fixed
Keywords: checkin-needed

Updated

5 years ago
Summary: multiple locales donn't build properly on win32, empty values break → multiple locales don't build properly on win32, empty values break
You need to log in before you can comment on or make changes to this bug.