800329 - multiple locales don't build properly on win32, empty values break

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[[e-mail] (:bhearsum)]

We got the following error when trying to build it:
Traceback (most recent call last):
  File "e:/builds/moz2_slave/rel-m-beta-w32-rpk-4/mozilla-beta/toolkit/mozapps/installer/windows/nsis/preprocess-locale.py", line 321, in <module>
    preprocess_locale_files(config_dir, l10n_dirs)
  File "e:/builds/moz2_slave/rel-m-beta-w32-rpk-4/mozilla-beta/toolkit/mozapps/installer/windows/nsis/preprocess-locale.py", line 110, in preprocess_locale_files
    True)
  File "e:/builds/moz2_slave/rel-m-beta-w32-rpk-4/mozilla-beta/toolkit/mozapps/installer/windows/nsis/preprocess-locale.py", line 48, in get_locale_strings
    if value[-1] == "\"" and value[0] == "\"":
IndexError: string index out of range
make[2]: *** [l10ngen/setup.exe] Error 1
make[1]: *** [repackage-win32-installer] Error 2
make: *** [repackage-win32-installer-km] Error 2

Comment 1

[Axel Hecht [:Pike]]

ok, this happens when a value is empty. This will affect more than just one locale, I assume (at least hy-AM is on my list of candidates, too).

I suggest we patch this in preprocess-locale.py, and make that bullet-proof.

Comment 2

[Axel Hecht [:Pike]]

Attachment: check for value before checking its contents

This patch applies to mozilla-beta, we should back-port it to aurora and central.

Taking ted as reviewer, as he's reviewing code there before.

Comment 3

[Axel Hecht [:Pike]]

PS: This has been the case since the initial port of preprocess-locale from perl to python, but only recently got triggered by some locales having empty strings in the installer .properties files.

Notably, that's in narro exports, AFAICT.

Either way, we should make the python script bullet proof, IMHO.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/057589f16a3a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/057589f16a3a

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 670370 [details] [diff] [review]
check for value before checking its contents

[Triage Comment]
We need this on Beta and Aurora too - Axel's away can someone check this in today please so it's in tomorrow's Beta build?

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/releases/mozilla-beta/rev/c9f397f91cce

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(Still c-n for aurora)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1796bbed0299