Closed Bug 800394 Opened 7 years ago Closed 7 years ago

The safebrowsing tests are fragile if SafeBrowsing is not yet initialized

Categories

(Toolkit :: Safe Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 19

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

There's nothing in the test to ensure that SafeBrowsing is initialized in time, so for example running just the browser/components/safebrowsing directory always fails.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #670410 - Flags: review?(gpascutto)
Comment on attachment 670410 [details] [diff] [review]
Patch (v1)

Review of attachment 670410 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, based on the analysis here: https://bugzilla.mozilla.org/show_bug.cgi?id=741808#c17

With a fresh profile there might be a race to get the test database initialized in under 2 seconds.
Attachment #670410 - Flags: review?(gpascutto) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/442540c013bb
Target Milestone: --- → Firefox 19
browser_bug400731.js still failing frequently:
https://tbpl.mozilla.org/php/getParsedLog.php?id=16021280&tree=Mozilla-Inbound
Blocks: 799526
Whiteboard: [leave open]
Blocks: 800854
I'm not sure why this was not closed when the patch landed.  This patch fixed these tests to have any chance of succeeding when run locally.  The tests are still flaky, but that should be the subject of bug 800854.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.