800394 - The safebrowsing tests are fragile if SafeBrowsing is not yet initialized

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[(no longer active)]

There's nothing in the test to ensure that SafeBrowsing is initialized in time, so for example running just the browser/components/safebrowsing directory always fails.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 670410 [details] [diff] [review]
Patch (v1)

Review of attachment 670410 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, based on the analysis here: https://bugzilla.mozilla.org/show_bug.cgi?id=741808#c17

With a fresh profile there might be a race to get the test database initialized in under 2 seconds.

Comment 3

[(no longer active)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/442540c013bb

Comment 4

[Ed Morley [:emorley]]

browser_bug400731.js still failing frequently:
https://tbpl.mozilla.org/php/getParsedLog.php?id=16021280&tree=Mozilla-Inbound

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/442540c013bb

Comment 6

[(no longer active)]

I'm not sure why this was not closed when the patch landed.  This patch fixed these tests to have any chance of succeeding when run locally.  The tests are still flaky, but that should be the subject of bug 800854.