Closed Bug 800481 Opened 7 years ago Closed 7 years ago

Remove unnecessary second arg from HashTable::hash{1,2}

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(1 file, 1 obsolete file)

The second argument of HashTable::hash{1,2}() is always |this->hashShift|.
So there's no point passing it in.  Removing it also avoids some confusing
shadowing in the case of hash2().
patch
Attachment #670487 - Flags: review?(luke)
Just for kicks, here's a version that compiles -- hash1 can no longer be
static (hash2 already was non-static).
Attachment #670492 - Flags: review?(luke)
Attachment #670487 - Attachment is obsolete: true
Attachment #670487 - Flags: review?(luke)
Comment on attachment 670492 [details] [diff] [review]
Remove unnecessary |hashShift| arg from HashTable::hash{1,2}.

good find!
Attachment #670492 - Flags: review?(luke) → review+
Depends on: 800659
https://hg.mozilla.org/mozilla-central/rev/0bf4db8c014c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.