Closed
Bug 800481
Opened 13 years ago
Closed 13 years ago
Remove unnecessary second arg from HashTable::hash{1,2}
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.94 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
The second argument of HashTable::hash{1,2}() is always |this->hashShift|.
So there's no point passing it in. Removing it also avoids some confusing
shadowing in the case of hash2().
|
Assignee | |
Comment 2•13 years ago
|
||
Just for kicks, here's a version that compiles -- hash1 can no longer be
static (hash2 already was non-static).
Attachment #670492 -
Flags: review?(luke)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #670487 -
Attachment is obsolete: true
Attachment #670487 -
Flags: review?(luke)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 670492 [details] [diff] [review]
Remove unnecessary |hashShift| arg from HashTable::hash{1,2}.
good find!
Attachment #670492 -
Flags: review?(luke) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•