Closed Bug 800508 Opened 11 years ago Closed 8 years ago

fout[i] appears to be undefined (stack garbage) in webrtc.org noise suppression code

Categories

(Core :: WebRTC: Audio/Video, defect, P3)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: jesup, Unassigned)

References

Details

Assigned value is garbage or undefined	media/webrtc/trunk/src/modules/audio_processing/ns/ns_core.c:1244	

It doesn't appear to be guaranteed not to be stack garbage in all paths.  Routine is very long, so it's hard to be sure, but a tool indicated a possible problem.

Upstream issue for webrtc.org

No security impact as it just will cause possible incorrect audio noise suppression.
Priority: -- → P3
Whiteboard: [WebRTC], [blocking-webrtc-]
Depends on: webrtc_updates
backlog: --- → webRTC+
Rank: 35
Whiteboard: [WebRTC], [blocking-webrtc-]
Is this still relevant?
Flags: needinfo?(rjesup)
QA Contact: jsmith
Routine was totally rewritten by upstream.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(rjesup)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.