fout[i] appears to be undefined (stack garbage) in webrtc.org noise suppression code

RESOLVED WORKSFORME

Status

()

P3
normal
Rank:
35
RESOLVED WORKSFORME
6 years ago
3 years ago

People

(Reporter: jesup, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
Assigned value is garbage or undefined	media/webrtc/trunk/src/modules/audio_processing/ns/ns_core.c:1244	

It doesn't appear to be guaranteed not to be stack garbage in all paths.  Routine is very long, so it's hard to be sure, but a tool indicated a possible problem.

Upstream issue for webrtc.org

No security impact as it just will cause possible incorrect audio noise suppression.
Blocks: 800579

Updated

6 years ago
Priority: -- → P3
Whiteboard: [WebRTC], [blocking-webrtc-]

Updated

6 years ago
Depends on: 818631

Updated

4 years ago
backlog: --- → webRTC+
Rank: 35
Whiteboard: [WebRTC], [blocking-webrtc-]
Is this still relevant?
Flags: needinfo?(rjesup)
QA Contact: jsmith
(Reporter)

Comment 2

3 years ago
Routine was totally rewritten by upstream.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(rjesup)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.