Closed
Bug 800524
Opened 12 years ago
Closed 12 years ago
Privacy status "Google Default" (CLASS:DEFAULT) breaks display of privacy icon in calendar view
Categories
(Calendar :: Provider: GData, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.9
People
(Reporter: ssitter, Assigned: Paenglab)
Details
Attachments
(2 files, 1 obsolete file)
6.25 KB,
image/jpeg
|
Details | |
1.18 KB,
patch
|
ssitter
:
review+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
The privacy status "Google Default" (CLASS:DEFAULT) that is used by the Provider for Google Calendar extension breaks display of privacy icon in calendar view. Both icons for "private" and "confidential" will be shown with incorrect size. See attached screenshot.
Comment 1•12 years ago
|
||
Richard, do you think you could look into this one? We probably just need to set a default css rule for the privacy icon.
Assignee | ||
Comment 2•12 years ago
|
||
Fixed it by adding the attribute classification="DEFAULT" to the rules.
Comment 3•12 years ago
|
||
Sorry if I wasn't clear enough. DEFAULT is not a real rfc state, its just what I used for Google to say it should use the default. I was rather thinking a patch that hides the icon if its not one of the values that deserves an icon.
Assignee | ||
Comment 4•12 years ago
|
||
Okay, this patch hides the icon on every state except PRIVATE and CONFIDENTIAL. I let PUBLIC as it's own rule for later usage if needed (actually it hides also the icon).
Attachment #670933 -
Attachment is obsolete: true
Attachment #670933 -
Flags: review?(ssitter)
Attachment #670937 -
Flags: review?(ssitter)
Reporter | ||
Updated•12 years ago
|
Attachment #670937 -
Flags: review?(ssitter) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/7a401d13af8f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 670937 [details] [diff] [review] patch v2 Should this go to aurora and beta to fix this issue as fast as possible?
Attachment #670937 -
Flags: approval-calendar-beta?
Attachment #670937 -
Flags: approval-calendar-aurora?
Comment 7•12 years ago
|
||
Comment on attachment 670937 [details] [diff] [review] patch v2 Yeah I think this is safe for beta and it would be nice to have this fixed for the ESR.
Attachment #670937 -
Flags: approval-calendar-beta?
Attachment #670937 -
Flags: approval-calendar-beta+
Attachment #670937 -
Flags: approval-calendar-aurora?
Attachment #670937 -
Flags: approval-calendar-aurora+
Assignee | ||
Comment 8•12 years ago
|
||
Pushed to comm-aurora: http://hg.mozilla.org/releases/comm-aurora/rev/fc47a61120e5 and comm-beta: http://hg.mozilla.org/releases/comm-beta/rev/ea5e36651e5e
Target Milestone: 2.1 → 1.9
Comment 9•12 years ago
|
||
It looks like this is being fixed in Lightning 1.9 which means Thunderbird 17? Is there anyway to patch around this in the Provider so we don't have to wait for Thunderbird 17 for a fix?
Assignee | ||
Comment 10•12 years ago
|
||
You could apply the changes directly on XPI file or in your profile. But if you are unsure how to do this it would be better to wait until the next version. You could also say when you have this two squeezed icons then this means no privacy (not really elegant but as a workaround until the next version).
Comment 11•12 years ago
|
||
FYI, A user in this thread pointed out that since its a CSS change we can change it in userchrome.css with this while we wait for the next Lightning. .item-classification-box { display: none !important; } https://getsatisfaction.com/mozilla_messaging/topics/new_lightning_icon_on_network_calendar_events_is_a_design_flaw
You need to log in
before you can comment on or make changes to this bug.
Description
•