800535 - nsSimplePageSequence.cpp:673:53: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug for new-ish build warning (using GCC 4.7):
{
/mozilla/layout/generic/nsSimplePageSequence.cpp: In member function ‘virtual nsresult nsSimplePageSequenceFrame::PrePrintNextPage(nsITimerCallback*, bool*)’:

/mozilla/layout/generic/nsSimplePageSequence.cpp:673:53: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}

...for this code:
> 664   int32_t doneCounter = 0;
[...]
> 669       doneCounter++;
[...]
> 672   // If all canvas have finished rendering, return true, otherwise false.
> 673   *aDone = doneCounter == mCurrentCanvasList.Length();
https://mxr.mozilla.org/mozilla-central/source/layout/generic/nsSimplePageSequence.cpp?mark=664-664,673-673#664

https://mxr.mozilla.org/mozilla-central/source/layout/generic/nsSimplePageSequence.cpp?mark=664-664,669-669,673-673#664

Looks like doneCounter should just be unsigned -- it starts at 0 and only increases from there, so there's no reason to make it a signed value.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9940b9d6f5f

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d9940b9d6f5f